Repository navigation
Conversation
ydsakshi
requested review from
XD-DENG,
amoghrajesh,
ashb,
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
henry3260,
jason810496,
jedcunningham,
pierrejeambrun,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 26, 2026 15:51
1 task done
shahar1
requested changes
Oct 31, 2026
shahar1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution!
The idea looks solid overall, the PR should be polished a bit more.
Besides, I think it's worth to post a discussion followed by lazy consensus on the dev list, since it involves migrations and schema changes (I wouldn't write a full AIP for that).
@uranusjr - you might want to take a look as well at some point.
| ) | ||
| return statement.where( | ||
| or_( | ||
| DagWarning.dag_id.in_(authorized), |
Contributor
There was a problem hiding this comment.
Anyone who can read one Dag in the file sees the stacktrace. For import errors from the same file, the API hides
the stacktrace unless the user can read all Dags in it. If no Dag in the file loaded, nobody can see the warning.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #29275.
Partial failures in dynamic DAG factories/files can call
emit_dag_warning()during file parse. The DAG processor takes those warnings onDagFileParsingResult& stores them indag_warningtable (with columns -bundle_name&filename) & exposes them via GET/api/v2/dagWarnings& a Dashboard parse-failure card.Reproduced the issue using the below sample script on
main& then verified the fix on feature branch.Evidence
Sample dynamic DAG creator file :-
Was generative AI tooling used to co-author this PR?
Not generated by AI, used Cursor for approach & design finalization. Code is fully vetted by me.
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.