Skip to content

Retry GitHub server errors in the fork CI monitor - #75692

Merged
potiuk merged 1 commit into
mainfrom
fork-ci-retry-server-errors
Oct 26, 2026
Merged

potiuk merged 1 commit into
mainfrom
fork-ci-retry-server-errors

Conversation

@potiuk

@potiuk potiuk commented Oct 26, 2026

Copy link
Copy Markdown
Member

A Fork CI monitor run failed on a single gh: HTTP 504 from GitHub's GraphQL search, which GitHub returns when a search takes too long on its side. The error came from discovery, before any pull request was reconciled, so the whole run was lost. Errors like this usually go away on the next try.

  • The fork CI GitHub client now retries HTTP 5xx answers with backoff (10, 20 and 40 seconds), the same way it already retries rate limits, up to four attempts in total.
  • Creating a comment is not retried after a server error, because the comment may have been created anyway and would be posted twice. Other mutations (labels, statuses, comment updates, closing, deleting runs) are safe to repeat.
  • A server error that outlasts the retries fails as before, with a still failing after 4 attempts message. The still rate limited message that dev/AGENTS.md tells people to look for is unchanged.

Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

🤖 Generated with Claude Code

A single HTTP 504 from GitHub's GraphQL search, which happens when a search
takes too long on GitHub's side, failed the whole Fork CI monitor run before
it reconciled any pull request. Such errors usually go away on the next try,
like the rate limits the monitor already waits out.

Generated-by: Claude Opus 5
@potiuk
potiuk merged commit d22f4e4 into main Oct 26, 2026
107 of 148 checks passed
@potiuk
potiuk deleted the fork-ci-retry-server-errors branch October 26, 2026 19:43
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-4-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-4-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 26, 2026
…#75692)

A single HTTP 504 from GitHub's GraphQL search, which happens when a search
takes too long on GitHub's side, failed the whole Fork CI monitor run before
it reconciled any pull request. Such errors usually go away on the next try,
like the rate limits the monitor already waits out.
(cherry picked from commit d22f4e4)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Generated-by: Claude Opus 5
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 26, 2026
…#75692)

A single HTTP 504 from GitHub's GraphQL search, which happens when a search
takes too long on GitHub's side, failed the whole Fork CI monitor run before
it reconciled any pull request. Such errors usually go away on the next try,
like the rate limits the monitor already waits out.
(cherry picked from commit d22f4e4)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Generated-by: Claude Opus 5
vatsrahul1001 pushed a commit that referenced this pull request Oct 27, 2026
#75693)

A single HTTP 504 from GitHub's GraphQL search, which happens when a search
takes too long on GitHub's side, failed the whole Fork CI monitor run before
it reconciled any pull request. Such errors usually go away on the next try,
like the rate limits the monitor already waits out.
(cherry picked from commit d22f4e4)


Generated-by: Claude Opus 5

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants