Repository navigation
[v3-4-test] Hide empty log groups in the task log view (#75686) - #75801
Merged
Merged
Conversation
The task runner always opens a "Post Execute" log group after execute() returns, but for a plain task nothing is logged at INFO before it is closed, so the UI showed a section header that expanded to nothing. When parsing logs, drop a group header if the group closes with no entries in it. A parent containing only empty groups is dropped too. Unclosed groups are kept so a running task still shows its current section. (cherry picked from commit 8f7a8e4) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
bbovenzi
approved these changes
Oct 27, 2026
bbovenzi
marked this pull request as ready for review
October 27, 2026 15:39
bbovenzi
requested review from
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 27, 2026 15:39
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task runner always opens a "Post Execute" log group after execute()
returns, but for a plain task nothing is logged at INFO before it is
closed, so the UI showed a section header that expanded to nothing.
When parsing logs, drop a group header if the group closes with no
entries in it. A parent containing only empty groups is dropped too.
Unclosed groups are kept so a running task still shows its current
section.
(cherry picked from commit 8f7a8e4)
Co-authored-by: Jed Cunningham 66968678+jedcunningham@users.noreply.github.com