Repository navigation
[v3-4-test] Isolate otel config-priority test from ambient OTEL env vars - #75843
Closed
vatsrahul1001 wants to merge 1 commit into
Closed
vatsrahul1001 wants to merge 1 commit into
vatsrahul1001 wants to merge 1 commit into
Conversation
test_config_priorities asserts that the Airflow config host/port is used when a case provides no OTEL endpoint env var. It applied only the case's provided_env_vars on top of the ambient environment, so any OTEL_* var already exported by the runner leaked in. RunsOn CI runners export OTEL_EXPORTER_OTLP_ENDPOINT (resolving to 127.0.0.1:4318), which wins over the Airflow config and failed the six config-priority cases on both main and the release branches. Clear all OTEL_* env vars before applying provided_env_vars so the test only sees its own inputs regardless of the runner environment. (cherry picked from commit 9f0a88b)
vatsrahul1001
requested review from
amoghrajesh,
ashb and
potiuk
as code owners
October 28, 2026 06:58
Contributor
Author
|
Closing in favour of #75844 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #75842 to
v3-4-test.Opened directly (rather than waiting on the auto-backport bot) to unblock the
v3-4-testCI gate for the RC1 cut — this shared-distributions/observability failure is currently red on every open PR into the branch. Thebackport-to-v3-4-testlabel has been removed from #75842 to avoid a duplicate auto-backport.Problem
TestOtelMetrics::test_config_prioritiesfails onv3-4-test(andmain) for the six cases that expect the Airflow config host/port to be used when no OTEL endpoint env var is provided:The test overlaid only each case's
provided_env_varswithout clearing other ambientOTEL_*vars. The RunsOn CI runners exportOTEL_EXPORTER_OTLP_ENDPOINT(→127.0.0.1:4318), which correctly wins over the Airflow config, so the resolved endpoint is wrong. The test is non-hermetic; the production code is correct. This is why it fails onmainand the release branches simultaneously — the runner env is shared.Fix
Clear all
OTEL_*env vars before applying the case'sprovided_env_vars, so the test only sees its own inputs regardless of the runner environment.Testing
Reproduced the six failures locally by exporting
OTEL_EXPORTER_OTLP_ENDPOINT, then confirmed all cases pass with the fix even with the ambient var set (10 passed).Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines