Repository navigation
Stop requesting the details of an empty Dag id after a bulk selection - #75862
Merged
Merged
Conversation
The Task Instances list keeps its bulk Clear dialog mounted once every row is unselected. With nothing to clear, the dialog's Dag id was an empty string, which still enabled the auto-refresh lookup and sent GET /dags//details, answered with a 404.
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 28, 2026
pierrejeambrun
marked this pull request as ready for review
October 28, 2026 11:49
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 28, 2026 11:50
An empty-string fallback on the shared Dag id lets any later use send it unnoticed. Only the two Dag and Dag run lookups need a string, and they run for a single run, when the Dag id is always set.
bbovenzi
approved these changes
Oct 28, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
shahar1
pushed a commit
that referenced
this pull request
Oct 29, 2026
…lk selection (#75862) * Stop requesting the details of an empty Dag id after a bulk selection The Task Instances list keeps its bulk Clear dialog mounted once every row is unselected. With nothing to clear, the dialog's Dag id was an empty string, which still enabled the auto-refresh lookup and sent GET /dags//details, answered with a 404. * Leave the Clear dialog's Dag id undefined when there is nothing to clear An empty-string fallback on the shared Dag id lets any later use send it unnoticed. Only the two Dag and Dag run lookups need a string, and they run for a single run, when the Dag id is always set. (cherry picked from commit 60d692b) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
pierrejeambrun
added a commit
that referenced
this pull request
Oct 29, 2026
…lk selection (#75862) (#75867) * Stop requesting the details of an empty Dag id after a bulk selection The Task Instances list keeps its bulk Clear dialog mounted once every row is unselected. With nothing to clear, the dialog's Dag id was an empty string, which still enabled the auto-refresh lookup and sent GET /dags//details, answered with a 404. * Leave the Clear dialog's Dag id undefined when there is nothing to clear An empty-string fallback on the shared Dag id lets any later use send it unnoticed. Only the two Dag and Dag run lookups need a string, and they run for a single run, when the Dag id is always set. (cherry picked from commit 60d692b) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 30, 2026
…lk selection (#75862) (#75867) * Stop requesting the details of an empty Dag id after a bulk selection The Task Instances list keeps its bulk Clear dialog mounted once every row is unselected. With nothing to clear, the dialog's Dag id was an empty string, which still enabled the auto-refresh lookup and sent GET /dags//details, answered with a 404. * Leave the Clear dialog's Dag id undefined when there is nothing to clear An empty-string fallback on the shared Dag id lets any later use send it unnoticed. Only the two Dag and Dag run lookups need a string, and they run for a single run, when the Dag id is always set. (cherry picked from commit 60d692b) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Task Instances list, unselecting the last selected row sends
GET /api/v2/dags//details, which the API answers with a 404.The bulk Clear button keeps its dialog mounted while the action bar is closed. With no task instance to clear, the dialog's Dag id fell back to an empty string and was handed to
useAutoRefresh, which only skips its Dag details lookup when the id isundefined. The dialog now passesundefinedwhen it has nothing to clear. The selection in the Grid view (#75221) goes through the same dialog, and a plain click that ends a multi-selection triggered the same request there.Requests to
/dags//while selecting one row of the Task Instances list, then unselecting it:Before
Screen.Recording.2026-10-28.at.12.49.39.mov
After
Screen.Recording.2026-10-28.at.12.48.59.mov
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines