Repository navigation
Vendor the Java SDK supervisor schema from this repository - #75942
Open
jason810496 wants to merge 12 commits into
Open
jason810496 wants to merge 12 commits into
jason810496 wants to merge 12 commits into
Conversation
boring-cyborg
Bot
added
area:dev-tools
area:java-sdk
backport-to-v3-4-test
1 task done
jason810496
force-pushed
the
feature/java-sdk-local-supervisor-schema
branch
2 times, most recently
from
November 2, 2026 09:09
aff20b7 to
7af6b46
Compare
jason810496
marked this pull request as ready for review
November 2, 2026 09:53
jason810496
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jscheffl,
potiuk and
uranusjr
as code owners
November 2, 2026 09:53
jason810496
force-pushed
the
feature/java-sdk-local-supervisor-schema
branch
from
November 3, 2026 02:11
7af6b46 to
f4024e3
Compare
The vendored copy was refreshed by downloading the version named in gradle.properties. The remote only publishes released versions, so an in-progress one cannot be fetched, and a schema change that leaves api_version alone moved nothing, so the copy went stale unnoticed. It is now copied from the schema the Python Task SDK owns and compared by content, the way sync-go-sdk-schemas already does for the Go SDK, so any change to the source moves it in the same commit. The download stays as the fallback for a build with no monorepo around it, which is what the source distribution needs. The refreshed copy is the content it never received while it was refreshed by version; api_version is unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
The pin is the supervisor schema version the Java SDK speaks; the vendored schema.json is a copy of whatever the bundle carries. Requiring the two to be equal made the pin follow main every time a supervisor version was cut. The prek hook now copies the source by content and only checks that the pin is a version the bundle defines, and the Gradle task copies the in-repo source whenever it exists instead of falling back to the download on a version mismatch, so the build and the hook agree. Co-Authored-By: Claude <noreply@anthropic.com>
jason810496
force-pushed
the
feature/java-sdk-local-supervisor-schema
branch
from
November 3, 2026 02:21
f4024e3 to
917cca8
Compare
uranusjr
approved these changes
Nov 5, 2026
uranusjr
left a comment
uranusjr
left a comment
Member
There was a problem hiding this comment.
I worked on the PR abit since it’s needed for another fix I want to get in. (Not strictly, just making things easier.) Please take a look @jason810496
Member
Author
Thanks, I will merge this after the Java SDK 1.0 is out to keep the Java SDK schema clean on v3-4-test. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Java SDK generates its supervisor message classes from a vendored copy of the supervisor schema, refreshed by downloading the version in
java-sdk/gradle.propertiesfrom the staged docs site. That had two problems:api_versionbump were missed. The hook compared versions, not content.The vendored copy now comes from the Task SDK schema in this repository.
airflowSupervisorSchemaVersionmust be a version the Task SDK schema bundle defines:sync-go-sdk-schemas. The hook also runs when the Task SDK schema changes.:sdk:syncSupervisorSchemafollows the same rules and no longer downloads anything. Outside the monorepo it fails if the vendored copy does not declare the pinned version, so a source release builds from the same schema as an in-repo build, without network access.The Java SDK stays on supervisor schema
2026-10-30. The vendored copy was behind what Airflow 3.4 ships for that version, so it is refreshed from the Task SDK schema in3.4.0rc3.