Skip to content

Make the bundle name less prominent in the Dag import error modals - #75958

Merged
bbovenzi merged 2 commits into
apache:mainfrom
astronomer:subtle-bundle-name-import-errors
Oct 29, 2026
Merged

bbovenzi merged 2 commits into
apache:mainfrom
astronomer:subtle-bundle-name-import-errors

Conversation

@pierrejeambrun

@pierrejeambrun pierrejeambrun commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

The bundle name was the first, bold item of each import error, both in the dashboard's import errors list and in the single import error dialog of a bundle's files. It drew more attention than the file that actually failed to parse. When only one bundle exists, it tells nothing apart.

The bundle name is now shown after the file name, muted and right-aligned. It is hidden when the user can see a single bundle. The bundle count comes from a limit=1 request to the bundles endpoint, which only reads total_entries.

Several bundles

Before After
Dashboard import errors
Bundle file import error

Single bundle

Before, this looked the same as with several bundles.

Dashboard import errors Bundle file import error

Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5.5)

Generated-by: Claude Code (Opus 5.5) following the guidelines

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 29, 2026
pierrejeambrun added a commit to astronomer/airflow that referenced this pull request Oct 29, 2026
pierrejeambrun added a commit to astronomer/airflow that referenced this pull request Oct 29, 2026

@ashb ashb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pierrejeambrun
pierrejeambrun marked this pull request as ready for review October 29, 2026 12:56
@pierrejeambrun pierrejeambrun added this to the Airflow 3.4.0 milestone Oct 29, 2026
@pierrejeambrun pierrejeambrun added the backport-to-v3-4-test Backport to v3-4-test label Oct 29, 2026

@choo121600 choo121600 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, but it seems like the CI is failing 🤔

The bundle name was the first, bold item of each import error, so it drew
more attention than the file that failed to parse. With a single bundle it
carries no information at all.
@pierrejeambrun
pierrejeambrun force-pushed the subtle-bundle-name-import-errors branch from d6cbac0 to 804bfa4 Compare October 29, 2026 16:13
@bbovenzi
bbovenzi merged commit 38b3c45 into apache:main Oct 29, 2026
82 checks passed
@bbovenzi
bbovenzi deleted the subtle-bundle-name-import-errors branch October 29, 2026 17:45
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-4-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-4-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 29, 2026
…or modals (apache#75958)

* Make the bundle name less prominent in the Dag import error modals

The bundle name was the first, bold item of each import error, so it drew
more attention than the file that failed to parse. With a single bundle it
carries no information at all.

* Label the bundle as Bundle in the Dag import error modals
(cherry picked from commit 38b3c45)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 29, 2026
…or modals (apache#75958)

* Make the bundle name less prominent in the Dag import error modals

The bundle name was the first, bold item of each import error, so it drew
more attention than the file that failed to parse. With a single bundle it
carries no information at all.

* Label the bundle as Bundle in the Dag import error modals
(cherry picked from commit 38b3c45)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
ashb pushed a commit that referenced this pull request Oct 29, 2026
…or modals (#75958)

* Make the bundle name less prominent in the Dag import error modals

The bundle name was the first, bold item of each import error, so it drew
more attention than the file that failed to parse. With a single bundle it
carries no information at all.

* Label the bundle as Bundle in the Dag import error modals
(cherry picked from commit 38b3c45)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Oct 30, 2026
…or modals (#75958)

* Make the bundle name less prominent in the Dag import error modals

The bundle name was the first, bold item of each import error, so it drew
more attention than the file that failed to parse. With a single bundle it
carries no information at all.

* Label the bundle as Bundle in the Dag import error modals
(cherry picked from commit 38b3c45)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
pierrejeambrun added a commit that referenced this pull request Oct 30, 2026
…or modals (#75958) (#75987)

* Make the bundle name less prominent in the Dag import error modals

The bundle name was the first, bold item of each import error, so it drew
more attention than the file that failed to parse. With a single bundle it
carries no information at all.

* Label the bundle as Bundle in the Dag import error modals
(cherry picked from commit 38b3c45)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Oct 30, 2026
…or modals (#75958) (#75987)

* Make the bundle name less prominent in the Dag import error modals

The bundle name was the first, bold item of each import error, so it drew
more attention than the file that failed to parse. With a single bundle it
carries no information at all.

* Label the bundle as Bundle in the Dag import error modals
(cherry picked from commit 38b3c45)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-4-test Backport to v3-4-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants