Repository navigation
[v3-4-test] Show UI doc screenshots in synced dark/light tabs (#75957) - #75960
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:UI
ashb
approved these changes
Oct 29, 2026
ashb
marked this pull request as ready for review
October 29, 2026 12:49
bbovenzi
enabled auto-merge (squash)
October 29, 2026 14:31
Almost every screenshot on the UI overview page was shown twice, once per theme, which roughly doubled the page length. Each pair is now a sphinx-design tab set in one sync group, so choosing a theme on any screenshot switches them all and the choice is remembered for the browser session. (cherry picked from commit 7468d31) Co-authored-by: Ash Berlin-Taylor <ash@astronomer.io>
vatsrahul1001
force-pushed
the
backport-7468d31-v3-4-test
branch
from
October 29, 2026 16:21
2586aef to
dd1ed6e
Compare
Contributor
Author
|
RunsOn re-runs them automatically when the run finishes; no action is needed. |
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 30, 2026
#75960) Almost every screenshot on the UI overview page was shown twice, once per theme, which roughly doubled the page length. Each pair is now a sphinx-design tab set in one sync group, so choosing a theme on any screenshot switches them all and the choice is remembered for the browser session. (cherry picked from commit 7468d31) Co-authored-by: Ash Berlin-Taylor <ash@astronomer.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost every screenshot on the UI overview page was shown twice, once per
theme, which roughly doubled the page length. Each pair is now a sphinx-design
tab set in one sync group, so choosing a theme on any screenshot switches them
all and the choice is remembered for the browser session.
(cherry picked from commit 7468d31)
Co-authored-by: Ash Berlin-Taylor ash@astronomer.io