Repository navigation
Conversation
Since apache#73503 the supervisor starts the task in a fresh interpreter with os.posix_spawn instead of forking and then exec-ing. The option's description, its 3.4.0 newsfragment and the security docs still told operators that the task process is forked first, which no longer matches what they get when they turn the option on, and they left out that at-fork handlers registered in the supervisor (the reason for apache#73503) no longer run in the task.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #73503, when
[core] execute_tasks_new_python_interpreteris on (and always on macOS), the task supervisor starts a fresh interpreter withos.posix_spawninstead offork()followed byexecv(). The option's description, its 3.4.0 newsfragment and the two security pages still say the task process is forked and thenexecs. That describes a mechanism the code no longer uses, and it leaves out the property that motivated #73503: at-fork handlers registered in the supervisor no longer run in the task.This is a docs-only change with no change in behaviour.
On
v3-4-testthe newsfragment has already been compiled intoRELEASE_NOTES.rst, so this will not cherry-pick cleanly. A manual backport that editsRELEASE_NOTES.rstinstead will follow.Checks run:
prek run --fileson the four files: every hook passed exceptcheck-default-configuration, which needs a Breeze CI image that I couldn't build locally. I ran its two commands,airflow config list --defaultand thenairflow config lint, inapache/airflow:3.4.0rc1-python3.12with this branch'sconfig.ymlmounted. The new description renders, and lint reports no issues.os.posix_spawndid not runos.register_at_forkhandlers, while a bareos.fork()ran bothbeforeandafter_in_child.sys.argv == ['-c']) withPR_GET_DUMPABLEat 0, which matches the updated security docs.related: #72164, #73503
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines
🤖 Generated with Claude Code