Skip to content

Derive the expected CI image name from the branch in Breeze CI image tests - #76206

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix-ci-image-test-branch
Nov 1, 2026
Merged

potiuk merged 1 commit into
apache:mainfrom
potiuk:fix-ci-image-test-branch

Conversation

@potiuk

@potiuk potiuk commented Nov 1, 2026

Copy link
Copy Markdown
Member

test_ci_image_commands.py compared the image Breeze inspects against a hard-coded ghcr.io/apache/airflow/main/ci/python3.11. On a release branch Breeze names the image after the branch, so after the backport of #74173 (#76183) test_load_restores_snapshot_with_the_checks_of_an_image_file_load fails on v3-4-test, which fails the "Breeze unit tests" job there. The test now builds the expected name with BuildCiParams(python="3.11").airflow_image_name, the same derivation the command uses, so it holds on main and on every release branch.

Verified: the test file passes on main (22 passed), and on v3-4-test the failing test fails before this change and the whole file passes after it.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Claude Opus 5)

Generated-by: Claude Code (Claude Opus 5) following the guidelines

…tests

The test hard-coded the main image name, so it fails on release branches such as v3-4-test, where Breeze names the image after the branch.

Generated-by: Claude Opus 5
@potiuk
potiuk merged commit b32439e into apache:main Nov 1, 2026
60 checks passed
@potiuk
potiuk deleted the fix-ci-image-test-branch branch November 1, 2026 11:03
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-4-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
❌ v3-4-test Commit Link

You can attempt to backport this manually by running:

cherry_picker b32439e v3-4-test

This should apply the commit to the v3-4-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants