Repository navigation
Keep CSV quoting in LLMFileAnalysisOperator sample rows - #76389
Merged
kaxil merged 2 commits intoNov 8, 2026
Merged
Conversation
aarmens702-hub
requested review from
Lee-W,
ashb,
gopidesupavan and
kaxil
as code owners
November 3, 2026 18:44
github-actions
Bot
added
need workflow approval
and removed
need workflow approval
labels
kaxil
reviewed
Nov 4, 2026
kaxil
approved these changes
Nov 4, 2026
The single value with both a quote and a line break meant dropping either character from the quoting set still passed. One case per character, plus a plain value that must stay unquoted.
kaxil
enabled auto-merge (squash)
November 4, 2026 12:37
github-actions
Bot
added
need workflow approval
and removed
need workflow approval
labels
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLMFileAnalysisOperator showed CSV sample rows with their quotes removed, so a value holding a comma or a line break looked like several values to the model. Values that need quoting are now quoted the way CSV quotes them, and all other values render as before.
Tested with a new
test_csv_values_keep_their_quotesintest_file_analysis.py(a quoted comma, an escaped quote and a line break). It fails on main and passes with this change.test_file_analysis.py,test_llm_file_analysis.pyandtest_object_storage.pypass (120 passed, 8 skipped because fastavro isn't installed).ruff format,ruff checkandmypyon the changed file are clean. I didn't run the fullprekset or breeze.closes: #76386
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines