Repository navigation
Conversation
Tab links on the dag, run and task instance pages rebuild the query string from scratch, so any filter set in the grid, gantt, graph or task log was dropped on every tab change, even though the panel it filters stays on screen. Switching task instances kept them only because grid links carry the params forward. The details layout now hands NavTabs the keys its panel owns, and NavTabs copies them onto every tab link. Those keys live in one list per source, read by the filters that write them and the views that apply them, with date ranges resolved to their start and end keys through the filter config, so a new filter is carried without a second list to keep in sync. Table paging and sorting stay behind, since they belong to one tab's list, and the browse and asset tabs carry nothing, as before. The log search query moves into the url (debounced), so it survives the unmount a tab change causes and a filtered log can be shared as a link. The XCom and Task Instances tables applied a run id pattern even with a run pinned by the route, where they offer no run id filter to clear it, so a pattern carried from the grid could empty them. They now apply it only on their lists across runs. Co-Authored-By: Claude <noreply@anthropic.com>
bbovenzi
force-pushed
the
fix-log-filters-reset-on-tab-change
branch
from
November 5, 2026 15:22
71c727c to
7a203e1
Compare
bbovenzi
marked this pull request as ready for review
November 5, 2026 18:33
bbovenzi
requested review from
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
November 5, 2026 18:33
Opening one map index from the mapped task instances table or the breadcrumb map index picker built the link from the region alone, so a log source, level or search set on the logs tab was gone by the time the instance's logs loaded, even though the same filters survive a tab change on that page. Those links now carry the panel's filters the way tab links do, while still leaving the list's paging and the previous try and region behind. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filters you set in the grid, gantt, graph or task log were lost whenever you switched tabs on a Dag, run or task instance page, even though the panel they filter stays on screen. Now they stay.
What changes
constants/persistentSearchParams.ts, so a new filter only needs adding there.log_search), so it survives tab changes and a filtered log can be shared as a link.stateandrun_typeon the Runs tab.Before / after
Same scripted clicks on
mainand on this branch: grid filtered toState: Failed, then Overview → Details → Code; then a task log filtered to INFO and searched for "bundles", then Logs → XCom → Logs.Testing
NavTabs,Logs,XComandTaskInstancescover which filters are carried, what is left behind, and the run id pattern case.pnpm lint,pnpm formatand the pre-commit hooks pass; the affected test files pass locally.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines