Repository navigation
Remove machine-global pnpm config causing .pnpm-store dir to be created in places - #76498
Merged
Merged
Conversation
…ed in places This was removed everywhere in #73538, but one extra case crept back in one day later via #73436 (I haven't checked, but likely the PR was opened/branched from before 73538 was opened, so one more instance came back). This had side-effects that were noticed multiple times before (#42119, #47342) but without thinking about what this is. pnpm's store dir is its global system wide cache, akin to the uv cache dir. By having this setting, each worktree or checkout that builds assets locally or runs e2e tests gets at least one (and sometimes multiple) cache dirs, usually taking 800MB-1GB. This stops it setting the global config setting, but doesn't clear it. To do that run this: ``` # Older Airflow prek hooks wrote this to your global pnpm config, # giving every checkout its own package store. pnpm config get store-dir # if this prints ".pnpm-store": pnpm config delete store-dir pnpm store path # should now point at the global store ```
ashb
requested review from
amoghrajesh,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
November 4, 2026 23:04
boring-cyborg
Bot
added
area:dev-tools
area:ts-sdk
backport-to-v3-4-test
Member
Author
|
For example, I found about 12Gb of .pnpm-store folders across various worktrees and providers etc. |
jedcunningham
approved these changes
Nov 4, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Nov 4, 2026
… to be created in places (apache#76498) (cherry picked from commit 9391e6a) Co-authored-by: Ash Berlin-Taylor <ash@astronomer.io>
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Nov 5, 2026
… to be created in places (apache#76498) (cherry picked from commit 9391e6a) Co-authored-by: Ash Berlin-Taylor <ash@astronomer.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed everywhere in #73538, but one extra case crept back in
one day later via #73436 (I haven't checked, but likely the PR was
opened/branched from before 73538 was opened, so one more instance came
back).
This had side-effects that were noticed multiple times before
(#42119, #47342) but without thinking about what this is.
pnpm's store dir is its global system wide cache, akin to the uv cache
dir. By having this setting, each worktree or checkout that builds
assets locally or runs e2e tests gets at least one (and sometimes
multiple) cache dirs, usually taking 800MB-1GB.
This stops it setting the global config setting, but doesn't clear it.
To do that run this:
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.