Repository navigation
Conversation
yuseok89
marked this pull request as ready for review
November 5, 2026 08:19
yuseok89
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
pierrejeambrun,
potiuk,
rawwar and
shubhamraj-git
as code owners
November 5, 2026 08:19
yuseok89
marked this pull request as draft
November 5, 2026 08:28
yuseok89
force-pushed
the
fix-masked-list-merge
branch
from
November 5, 2026 08:40
35aa746 to
9bc82a8
Compare
yuseok89
marked this pull request as ready for review
November 5, 2026 08:40
Contributor
|
Fork CI: running. CI for the latest commit is running in your fork. Pull requests from contributors run their CI in the contributor's own fork. GitHub Actions is free and has no minute limit on public forks, while the CI capacity of the Apache Software Foundation is shared by every ASF project and is finite. Latest run: https://github.com/yuseok89/airflow/actions/runs/42484795752 How this works: fork CI for external contributors. This comment was posted automatically by the fork CI monitor from templates drafted with an AI-assisted tool, so it may contain mistakes. An Apache Airflow maintainer, a real person, will review the pull request once its fork CI is green. Why the first pass is automated. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a Variable or a Connection's
extrain the UI sends secrets back as***, andmerge()restored them by list position. Removing, inserting or reordering list items gave one item another item's secret, or saved***as the value.merge()now matches each list item to the stored item it was shown for, so every secret stays with its own item. When a masked value could belong to more than one stored item, or to none, the save is rejected with a 400 instead of guessing. The form shows the message in its existing error alert and keeps the user's edits.Follow-up to #76012, which kept this as a known limitation.
closes: #76512
Before / After
Stored
{"users": [alice:A, bob:B, carol:C]}as a Variable value or a Connectionextra, edited in the form where every password shows as***.***[{"token": "***"}, {"token": "***"}]A rejected save in the UI. The message names the list whose masked values could not be placed, and the form stays open with the edits.
Items are grouped by their shown form, so matching stays linear in the list length, and saving 10,000 records takes about a second.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.