Skip to content

Clarify Google connection secret settings and retry default - #76622

Merged
shahar1 merged 4 commits into
apache:mainfrom
pavansai1997:docs-google-secret-settings-retry-default
Nov 7, 2026
Merged

shahar1 merged 4 commits into
apache:mainfrom
pavansai1997:docs-google-secret-settings-retry-default

Conversation

@pavansai1997

@pavansai1997 pavansai1997 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Two small corrections to the Google Cloud connection documentation:

  • Add the missing Keyfile Secret Project Id entry: explain the ADC-discovered project fallback, when an explicit value is needed, and that the connection's Project Id is not used for secret lookup.
  • Correct the documented request-retry default from 0 to 5, matching GoogleBaseHook.num_retries and the provider schema.

Existing secret-name wording, field references, and surrounding explanations are unchanged.

Secret-backed credentials need a distinct lookup project and bootstrap identity. The missing field description obscures those requirements, and the documented retry default disagrees with the connection schema.
@pavansai1997
pavansai1997 requested a review from shahar1 as a code owner November 6, 2026 17:44
@boring-cyborg boring-cyborg Bot added area:providers kind:documentation provider:google Google (including GCP) related issues labels Nov 6, 2026
@shahar1
shahar1 merged commit b37cd0d into apache:main Nov 7, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants