Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the Ingress version-label and documentation-check updates.
No open issues 🎉
What changed in this PR
Corrects the Ingress Controller documentation’s displayed version using the synced release ref and strengthens rendered documentation checks. URLs, redirects, and the API7-owned canonical strategy remain unchanged.
Changes:
- Derives the Ingress version label from the synced release ref, leaving other subprojects unchanged.
- Adds Dashboard and Deployment Modes to canonical, robots, and sitemap checks.
- Requires a valid Ingress release ref and checks that the overview and API Reference display it.
| File | Description |
|---|---|
next/tests/fixtures/documentation-search-signals.mjs |
Adds Dashboard and Deployment Modes to APISIX-owned page checks. |
next/src/lib/content.ts |
Uses the synced Ingress release ref for its version label. |
next/scripts/check-documentation-ownership-signals.mjs |
Validates the Ingress release ref and displayed version on two built pages. |
Review effort: Balanced
kayx23
approved these changes
Nov 17, 2026
bzp2010
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The current Ingress Controller docs are synced from the
v2.2.0release ref, but that ref'sdocs/en/latest/config.jsonstill declares0.3.0. As a result, the current docs display an outdatedv0.3.0version label. The audited APISIX-owned pages are already indexable and self-canonical; this is a reader-facing version accuracy fix and regression protection, not a demonstrated fix for their traffic decline.Changes
Validation
node --checkpassed for all three changed files.git diff --checkpassed.test:doc-signalsremain the rendered-output gate.