feat(arrow/compute): implement "is_in" function#319
Merged
zeroshade merged 2 commits intoapache:mainfrom Mar 24, 2025
Merged
Conversation
lidavidm
approved these changes
Mar 22, 2025
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Is it just me or are there a lot of unrelated changes mixed in here? 😅
Member
Author
|
@lidavidm while i was doing this i went a fixed a bunch of linting thingies that i came across and didn't feel like it was important enough to shift them to a separate PR haha. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Since we use arrow-go for iceberg-go and utilize the compute libraries for filtering, we need to ensure we add support for the minimal number of functions that iceberg requires.
What changes are included in this PR?
Implementing the
is_infunction for the function registry, registering it by default, and ensuring we also allow usingis_infrom substrait.Are these changes tested?
Yes, unit tests are included.
Are there any user-facing changes?
There shouldn't be any user-facing changes.