fix(parquet/pqarrow): fix propagation of FieldIds for nested fields#324
Merged
zeroshade merged 2 commits intoapache:mainfrom Mar 24, 2025
Merged
fix(parquet/pqarrow): fix propagation of FieldIds for nested fields#324zeroshade merged 2 commits intoapache:mainfrom
zeroshade merged 2 commits intoapache:mainfrom
Conversation
lidavidm
approved these changes
Mar 22, 2025
zeroshade
force-pushed
the
field-id-metadata
branch
from
a1bbb1c to
58b763a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While implementing things for iceberg-go, I found that an Arrow schema with nested fields (struct/map/list) that contains metadata values for FieldID is not respected when writing a file using
pqarrow.What changes are included in this PR?
Fixes the propagation of field ids when constructing a Parquet file from an arrow schema that contains nested fields, while also adding a
FileMetadatafunction to the FileWriter andpqarrow.FileWriterso that you can inspect the metadata of a written file without having to read it back into memory.Are these changes tested?
Yes
Are there any user-facing changes?
No