Skip to content

feat(arrow/_examples): enhance library examples#394

Merged
zeroshade merged 9 commits intoapache:mainfrom
kris-gaudel:main
Jun 12, 2025
Merged

feat(arrow/_examples): enhance library examples#394
zeroshade merged 9 commits intoapache:mainfrom
kris-gaudel:main

Conversation

@kris-gaudel
Copy link
Contributor

@kris-gaudel kris-gaudel commented May 30, 2025

Rationale for this change

Enhancing the library examples

What changes are included in this PR?

3 new examples on how to use the arrow-go library:

  • Reading from a CSV file
  • Type conversions
  • Managing performance

Are these changes tested?

Not applicable

Are there any user-facing changes?

No, just enhancing examples

@zeroshade
Copy link
Member

Instead of using the _examples folder, could we instead make these testable examples in the appropriate locations so they show up in the docs directly next to the relevant code?

@zeroshade
Copy link
Member

Some files are missing the Apache license header, adding that should fix the CI

@zeroshade
Copy link
Member

hey i'm super sorry this is taking so long! I've been traveling for a conference. I'll review this and hopefully merge it today

Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great examples! Thanks so much for this

@zeroshade
Copy link
Member

@kris-gaudel looks like you need to update the tinygo test script because you renamed/moved the helloworld/main.go file 😄 that's probably the last thing we need before we can merge this

@kris-gaudel
Copy link
Contributor Author

It looks like there is a memory leak in one of the tests, should I fix it in this PR or make a separate one?

@zeroshade
Copy link
Member

That's a transient leak that I haven't been able to track down myself. If you're able to track it down and fix it, that would be amazing! It can definitely be a separate PR and doesn't need to be dealt with in this one.

@zeroshade zeroshade merged commit 8be5e69 into apache:main Jun 12, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants