feat(arrow/compute): support some float16 casts#430
Merged
zeroshade merged 4 commits intoapache:mainfrom Jul 7, 2025
Merged
Conversation
zeroshade
commented
Jun 30, 2025
lidavidm
approved these changes
Jun 30, 2025
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
This is technically a breaking change then right?
Member
Author
|
Yea, I'm trying to figure out if there's a way I can do this easily without making the breaking change part. |
lidavidm
approved these changes
Jul 4, 2025
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
I think we can update the PR description now that there's no change to the float16 API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #424
Rationale for this change
Support casting float16 arrays to/from int and float32/float64
What changes are included in this PR?
Implementation of new casting kernels for cast_float, cast_half_float, cast_int32
Are these changes tested?
Unit tests are added to account for this.
Are there any user-facing changes?
No