refactor: switch golang.org/x/exp to standard library packages #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
Jul 28, 2025
Comment on lines
-54
to
64
|
|
||
| func Min[T constraints.Ordered](a, b T) T { | ||
| func Min[T cmp.Ordered](a, b T) T { | ||
| if a < b { | ||
| return a | ||
| } | ||
| return b | ||
| } | ||
|
|
||
| func Max[T constraints.Ordered](a, b T) T { | ||
| func Max[T cmp.Ordered](a, b T) T { | ||
| if a > b { | ||
| return a | ||
| } |
Member
There was a problem hiding this comment.
I need to get around to removing these entirely and just using the updated built-ins.... but that doesn't have to happen for this PR
zeroshade
approved these changes
Jul 28, 2025
Member
|
Thanks for this! It's something I've been meaning to get to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This change migrates several of usages of
golang.org/x/exppackages to use the standard library equivalents that have been introduced into newer go versions.What changes are included in this PR?
This change is a single commit
behavior-wise, this is intended to be a noop
Are these changes tested?
Tested with
go test ./.... I get the exact same behavior (including some failures) as on master.Are there any user-facing changes?
n/a