fix(arrow/compute): Fix scalar comparison batches #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoeba
approved these changes
Aug 8, 2025
Member
amoeba
left a comment
amoeba
left a comment
There was a problem hiding this comment.
LGTM
Tested the new test fails with the old code.
|
@zeroshade Is it possible to get a patch release for this issue? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #464
What changes are included in this PR?
Ensure the size of the slice used in scalar comparisons stays within the expected batch size
Are these changes tested?
Yes a test is added.
Are there any user-facing changes?
A condition that previously resulted in panic will now succeed