Skip to content

Conversation

@MasslessParticle
Copy link
Contributor

Rationale for this change

The typed dict encoder tries to cast memory.Allocator to TypedMemoTable. This results in a panic.

What changes are included in this PR?

This PR changes mem to memo in the encoder so the MemoTable is the variable cast to TypedMemoTable.

Are these changes tested?

I've tested this locally and panics no longer happen 🎉

@zeroshade
Copy link
Member

Thanks for finding this!

There wasn't any test cases which hit this before?

Would you be able to add a test case that hits this to ensure we don't have any regressions in the future?

@zeroshade
Copy link
Member

@MasslessParticle any luck on adding a test for this?

@MasslessParticle
Copy link
Contributor Author

@zeroshade Sorry, I got distracted last week. I've added a very basic test. I've only just started learning about the arrow ecosystem so it doesn't capture any other context than "we can call this without a panic or error."

Let me know what you think.

Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@zeroshade zeroshade merged commit d715ac7 into apache:main Aug 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants