[Go][Parquet] Refactor: extract visitListLike helper for list-like types #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract common logic for LIST, MAP, and FIXED_SIZE_LIST into a shared visitListLike helper function. This ensures nullableInParent is always set correctly before visiting child values, making it impossible to forget this step when adding new list-like type handling. The defLevelOffset parameter allows each type to specify how defLevelIfEmpty should be calculated relative to maxDefLevel after all increments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
rmorgans
force-pushed
the
refactor-visitlistlike
branch
from
8e4c876 to
6a09d78
Compare
zeroshade
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
visitListLikehelper functionnullableInParentis always set correctly before visiting child values, making it impossible to forget this step when adding new list-like type handlingdefLevelOffsetparameter to calculatedefLevelIfEmptyafter all incrementsRationale
This refactoring follows the principle of "making invalid states unrepresentable". The original bug in #584 (fixed in #585) was caused by the FIXED_SIZE_LIST case forgetting to set
nullableInParent. By extracting the common pattern into a helper function, future additions of list-like types cannot omit this critical step.Test plan
TestFixedSizeListNullableElements) continues to pass🤖 Generated with Claude Code