GH-1134: add COLUMN_DEF support to JDBC getColumnns()#1139
GH-1134: add COLUMN_DEF support to JDBC getColumnns()#1139Verest wants to merge 1 commit intoapache:mainfrom
Conversation
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
|
I am murky on the specific format for Since this is a generic JDBC driver, I am cautious to make assumptions about the incoming format of the Open to suggestions here. Aside: this PR should be an enhancement, but I do not have permission to edit the labels. |
|
Should this be discussed and voted like it was done for is_update? Maybe it is overkill but I think at least apache/arrow/FlightSql.proto should be in sync. There are other places in FlightSql.proto that also mention metadata returned that probably would need to be updated |
|
Have you thought if it would make sense in CommandGetXdbcTypeInfo? |
Yes, the proto files in this repo should mirror the main one. |
What's Changed
Updates the
FlightSqlColumnMetadatato contain the JDBCCOLUMN_DEFfield alongside getters/setters. Following exiting naming format.Updates
ArrowDatabaseMetadatato write to the pre-existingCOLUMN_DEFvector as part of thegetColumns()code paths.Updates test(s) in
ArrowDatabaseMetadataTestto test default value behavior.Closes #1134.