Conversation
|
The failing emulator tests seem unrelated? |
|
Here is a proposed fix for the emulator tests: |
alamb
left a comment
There was a problem hiding this comment.
Thank you @kylebarron
This seems like it does what it is designed to do. I don't know much about azure
Is the path format documented anywhere that I can double check?
|
I also don't know the most about Azure; I've only started working with it recently. I don't know where these URL patterns are documented; it's just my understanding that the first part of the path is the container name. |
Looks like here? https://learn.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-containers--blobs--and-metadata#resource-uri-syntax
There is also a section about a root container that I'm not familiar with. |
|
Thanks again @kylebarron |
Which issue does this PR close?
ObjectStoreScheme::parsefor Azure HTTP urls #398.Rationale for this change
Is there a spec for each of these URL formats? In my usage of Azure so far it seems like Azure URLs like
https://blob.core.windows.net/always have the container as the first element of the URL path. Is that true?Refer to the tests updated in this PR and ensure that you agree with the edited versions of them.
What changes are included in this PR?
Fixed parsing paths from Azure URLs.
Are there any user-facing changes?
Yes. Up to consideration whether this is a bug fix or a breaking change.