Improve performance of elementwise ByteViewArray concatenation#10161
Open
pepijnve wants to merge 1 commit into
Open
Improve performance of elementwise ByteViewArray concatenation#10161pepijnve wants to merge 1 commit into
pepijnve wants to merge 1 commit into
Conversation
Contributor
Author
|
I'll fix the MSRV issue as soon as I can. |
Contributor
Author
|
@neilconway thought you might find this one interesting as well. I'm thinking of making a similar PR for the concat functions in DataFusion. The semantics wrt null handling are different compared to |
pepijnve
force-pushed
the
concat_view
branch
4 times, most recently
from
e718dee to
8b2a515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
During profiling of a DataFusion query String concatenation, in particular of two StringView arrays, proved to be a hotspot.
This MR proposes a revised version of
concat_elements_string_view_arraywhich eliminates some overhead that comes from using a fairly generic implementation strategy.Benchmarking shows improvement of 20-40%.
What changes are included in this PR?
StringViewBuilderbased concatenation implementation with one that directly writes the various buffers of the arrayAre these changes tested?
Are there any user-facing changes?
No