Fix arrow-json writer empty#6614
Merged
Merged
Conversation
The Writer output with the ArrayJson formatter was empty when no record were in the output (no write or empty batch write). It should output an empty JSON array `[]` instead.
|
Hey folks, I'm not sure if this should have gone out as a minor release, as it will break anyone who assumes that there is no output if there were no rows. We were working around the lack of output by adding the [] ourselves. Super glad we don't have to do that any more, but sadly Cargo automatically bumped the minor version and now we see |
Contributor
|
Apologies that this broke your workflow, I viewed this a bug fix and therefore it was appropriate to roll out in a non-breaking release. |
|
ok, makes sense to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Writer output with the ArrayJson formatter was empty when no record were in the output (no write or empty batch write). It should output an empty JSON array
[]instead.Closes #6613