Repository navigation
fix: Build against flatbuffers 25.12.19 - #201
Open
sidpug-arcana wants to merge 3 commits into
Open
sidpug-arcana wants to merge 3 commits into
sidpug-arcana wants to merge 3 commits into
Conversation
This was referenced Oct 28, 2026
Contributor
Author
|
@kou can you review and merge if this is okay ?? |
Member
|
Could you work on #203 before this for easy to review? Could you also update the PR title to follow Conventional Commits? |
Bumps [github.com/google/flatbuffers](https://github.com/google/flatbuffers) from 25.2.10 to 25.12.19. - [Release notes](https://github.com/google/flatbuffers/releases) - [Commits](google/flatbuffers@v25.2.10...v25.12.19) --- updated-dependencies: - dependency-name: github.com/google/flatbuffers dependency-version: 25.12.19 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
sidpug-arcana
force-pushed
the
fix/flatbuffers-25.12.19
branch
from
November 2, 2026 05:44
83c0262 to
664e3a1
Compare
sidpug-arcana
changed the title
Regenerate the Swift FlatBuffers sources with flatc 25.12.19 and adapt the hand-written code to the new generated/runtime API: - Vector accessors changed from `xxxCount`/`xxx(at:)` to typed Vector collections (`xxx.count`, `xxx[i]`) - `FlatBufferObject` protocol split into `FlatBufferTable` / `FlatBufferStruct` - `ByteBuffer(data:allowReadingUnalignedBuffers:)` was removed from the runtime; drop the now-obsolete `useUnalignedBuffers` plumbing from the IPC readers and ArrowFlight - gen-flatbuffers.sh: add ARROW_FORMAT_DIR override and fix paths for the current repository layout Co-authored-by: Siddharth Pugalia <sidpug@gmail.com>
Adapt the tests merged from main (TimeBitWidthTests, IPCTests) to the new FlatbufferVector collection accessors. Co-authored-by: Siddharth Pugalia <sidpug@gmail.com>
sidpug-arcana
force-pushed
the
fix/flatbuffers-25.12.19
branch
from
November 2, 2026 10:21
664e3a1 to
3c11295
Compare
Contributor
Author
|
@kou can you check again i tried to update the things as per the convention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Supersedes #160 (chore: bump github.com/google/flatbuffers from 25.2.10 to 25.12.19), which fails CI on its own because the committed generated code was built with flatc 25.2.10 and is incompatible with the 25.12.19 runtime.
This PR includes the version bump from #160 plus the changes required to build and pass tests against the new runtime:
*_generated.swift) with flatc 25.12.19, using theformat/*.fbsschemas from apache/arrow (7151dcd6fa, i.e. the same schema revision the previous generated code was based on).xxxCount/xxx(at:)to typedVectorcollections (xxx.count,xxx[i]).FlatBufferObjectprotocol split intoFlatBufferTable/FlatBufferStruct.ByteBuffer(data:allowReadingUnalignedBuffers:)was removed from the runtime, so the now-obsoleteuseUnalignedBuffersplumbing was dropped from the IPC readers and ArrowFlight.gen-flatbuffers.sh: added anARROW_FORMAT_DIRoverride and fixed the paths for the current repository layout.Testing
Built and ran the full test suite locally (macOS, Swift 6.4), including the IPC file tests with fixtures generated by
data-generator/swift-datagen:Fixes #160.