Repository navigation
Conversation
…scans Pass per-file top-level field indices to the ORC batch reader so literal dotted names cannot be confused with nested paths. Preserve the existing name-based API and add adapter and Dataset regression coverage. Signed-off-by: jiangxt2 <jiangxt2@vip.qq.com>
|
|
…C scans Resolve materialized references against the Dataset schema before mapping them to per-file fields. Preserve positional identity for matching schemas and add projection, filter, and reader-schema regression coverage. Signed-off-by: jiangxt2 <jiangxt2@vip.qq.com>
jiangxt2
marked this pull request as ready for review
November 4, 2026 04:19
jiangxt2
requested review from
AlenkaF,
raulcd,
rok and
wgtmac
as code owners
November 4, 2026 04:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ORC Dataset scans can confuse a literal top-level field such as
a.bwith the nested patha/b. This can replace stored values with nulls and cause filters to discard matching rows.Fixes #55326.
What changes are included in this PR?
GetRecordBatchReaderByIndices, reusing integer selection and streaming reader construction while preserving the existing name-based API and its empty-initializer-list calls.Are these changes tested?
Validated with matching C++ and Python builds on macOS arm64, using CPython 3.13.7 and liborc 2.2.1.
cpp/build/dev/release/arrow-orc-adapter-test: 41 passed; one existing timezone-database check is skipped because it applies only to ORC versions before 2.0.cpp/build/dev/release/arrow-dataset-file-orc-test: 27 passed.clang-format, cpplint, autopep8, Flake8, and
git diff --checkpassed.Are there any user-facing changes?
ORC Dataset full scans, projections, and filters preserve the correct fields when literal dotted names collide with nested paths, including positional references and reordered file schemas. Existing name-based ORCFile selector semantics are preserved.
This PR contains a "Critical Fix". It corrects silent null substitution and dropped rows in query results.
Was AI used for this PR?
Codex generated the code, tests, and PR description and performed local review and verification.
PR code and description written by:
Reviewed before submission by: