Skip to content

GH-55411: [CI][Dev] Remove PR workflow (awaiting xxx) and associated logic and labels - #55412

Open
raulcd wants to merge 1 commit into
apache:mainfrom
raulcd:GH-55411
Open

raulcd wants to merge 1 commit into
apache:mainfrom
raulcd:GH-55411

Conversation

@raulcd

@raulcd raulcd commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Rationale for this change

Due to GitHub removing the pull_request_target event on PRs we should update our current workflows that use that event.

The PR workflow tried to improve our Workflow by adding something similar to what CPython uses on their workflow. It never worked for us. One of the problems is that we have some competing events because we don't consistently use the "request changes" on our PR reviews. This made the whole workflow really complex and not useful at all.

What changes are included in this PR?

Remove the whole "awaiting review"/"awaiting changes"/"awaiting committer review" workflow and the related code, test and fixtures.

Are these changes tested?

archery is tested on CI.

Are there any user-facing changes?

No but we won't use those workflow labels anymore

Was AI used for this PR?

In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

I did use AI to validate I wasn't missing any pieces to be removed.

Copilot AI balanced review requested due to automatic review settings November 5, 2026 09:02
@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Nov 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the PR-label automation removal.

No open issues 🎉

What changed in this PR

Removes Arrow’s automated “awaiting …” PR-label workflow, as requested in GH-55411, while retaining Archery’s comment-command bot.

Changes:

  • Deletes the label bot workflows and PR-state management logic.
  • Simplifies trigger-bot to handle comment events only and removes the committers-file option.
  • Removes obsolete workflow tests and fixtures.
File Description
dev/​archery/​archery/​tests/​test_bot.py Removes PR-label workflow tests and imports.
dev/​archery/​archery/​tests/​fixtures/​pull-request-26-commit.json Deletes the commit-response fixture.
dev/​archery/​archery/​tests/​fixtures/​pull-request-26-awaiting-review.json Deletes the workflow PR fixture.
dev/​archery/​archery/​tests/​fixtures/​label-awaiting-review.json Deletes the awaiting-review label fixture.
dev/​archery/​archery/​tests/​fixtures/​label-awaiting-changes.json Deletes the awaiting-changes label fixture.
dev/​archery/​archery/​tests/​fixtures/​label-awaiting-change-review.json Deletes the awaiting-change-review label fixture.
dev/​archery/​archery/​tests/​fixtures/​event-pull-request-target-synchronize.json Deletes the synchronization event fixture.
dev/​archery/​archery/​tests/​fixtures/​event-pull-request-target-opened-non-committer.json Deletes the non-committer PR-opening fixture.
dev/​archery/​archery/​tests/​fixtures/​event-pull-request-target-opened-committer.json Deletes the committer PR-opening fixture.
dev/​archery/​archery/​tests/​fixtures/​event-pull-request-opened.json Deletes the PR-opened event fixture.
dev/​archery/​archery/​tests/​fixtures/​event-pr-review-non-committer.json Deletes the non-committer review fixture.
dev/​archery/​archery/​tests/​fixtures/​event-pr-review-committer.json Deletes the committer review fixture.
dev/​archery/​archery/​cli.py Restricts bot dispatch to comment events.
dev/​archery/​archery/​bot.py Removes the PR-state enum, workflow bot, and related helpers.
.github/​workflows/​pr_review_trigger.yml Deletes the review-payload forwarding workflow.
.github/​workflows/​pr_bot.yml Deletes the PR-label automation workflow.

Review effort: Balanced

@raulcd

raulcd commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

@kou @pitrou what do you think about removing all this?

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Could you also remove

arrow/dev/merge_arrow_pr.py

Lines 347 to 355 in 1ebb937

def clear_pr_state_labels(self, number):
url = f'{self.github_api}/issues/{number}/labels'
response = requests.get(url, headers=self.headers)
labels = response.json()
for label in labels:
# All PR workflow state labels starts with "awaiting"
if label['name'].startswith('awaiting'):
label_url = f"{url}/{label['name']}"
requests.delete(label_url, headers=self.headers)
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting committer review Awaiting committer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants