Repository navigation
Conversation
…iated logic and labels
raulcd
requested review from
assignUser,
jonkeane,
kou and
pitrou
as code owners
November 5, 2026 09:02
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the PR-label automation removal.
No open issues 🎉
What changed in this PR
Removes Arrow’s automated “awaiting …” PR-label workflow, as requested in GH-55411, while retaining Archery’s comment-command bot.
Changes:
- Deletes the label bot workflows and PR-state management logic.
- Simplifies
trigger-botto handle comment events only and removes the committers-file option. - Removes obsolete workflow tests and fixtures.
| File | Description |
|---|---|
dev/archery/archery/tests/test_bot.py |
Removes PR-label workflow tests and imports. |
dev/archery/archery/tests/fixtures/pull-request-26-commit.json |
Deletes the commit-response fixture. |
dev/archery/archery/tests/fixtures/pull-request-26-awaiting-review.json |
Deletes the workflow PR fixture. |
dev/archery/archery/tests/fixtures/label-awaiting-review.json |
Deletes the awaiting-review label fixture. |
dev/archery/archery/tests/fixtures/label-awaiting-changes.json |
Deletes the awaiting-changes label fixture. |
dev/archery/archery/tests/fixtures/label-awaiting-change-review.json |
Deletes the awaiting-change-review label fixture. |
dev/archery/archery/tests/fixtures/event-pull-request-target-synchronize.json |
Deletes the synchronization event fixture. |
dev/archery/archery/tests/fixtures/event-pull-request-target-opened-non-committer.json |
Deletes the non-committer PR-opening fixture. |
dev/archery/archery/tests/fixtures/event-pull-request-target-opened-committer.json |
Deletes the committer PR-opening fixture. |
dev/archery/archery/tests/fixtures/event-pull-request-opened.json |
Deletes the PR-opened event fixture. |
dev/archery/archery/tests/fixtures/event-pr-review-non-committer.json |
Deletes the non-committer review fixture. |
dev/archery/archery/tests/fixtures/event-pr-review-committer.json |
Deletes the committer review fixture. |
dev/archery/archery/cli.py |
Restricts bot dispatch to comment events. |
dev/archery/archery/bot.py |
Removes the PR-state enum, workflow bot, and related helpers. |
.github/workflows/pr_review_trigger.yml |
Deletes the review-payload forwarding workflow. |
.github/workflows/pr_bot.yml |
Deletes the PR-label automation workflow. |
Review effort: Balanced
4 of 5 tasks
Member
Author
kou
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Due to GitHub removing the
pull_request_targetevent on PRs we should update our current workflows that use that event.The PR workflow tried to improve our Workflow by adding something similar to what CPython uses on their workflow. It never worked for us. One of the problems is that we have some competing events because we don't consistently use the "request changes" on our PR reviews. This made the whole workflow really complex and not useful at all.
What changes are included in this PR?
Remove the whole "awaiting review"/"awaiting changes"/"awaiting committer review" workflow and the related code, test and fixtures.
Are these changes tested?
archery is tested on CI.
Are there any user-facing changes?
No but we won't use those workflow labels anymore
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
I did use AI to validate I wasn't missing any pieces to be removed.