[AURON #1917] Clean up Clippy format/string lints (#1948)

# Which issue does this PR close?

Closes #1917

# Rationale for this change

Improve Rust code quality.

# What changes are included in this PR?

# Are there any user-facing changes?

# How was this patch tested?

Author: lemorage

Cargo.toml

@@ -75,11 +75,6 @@ while_let_loop = "allow"
 while_let_on_iterator = "allow"
 explicit_counter_loop = "allow"
 
-# Format/String
-useless_format = "allow"
-uninlined_format_args = "allow"
-to_string_in_format_args = "allow"
-
 # Code Style/Redundancy (Part 1)
 needless_borrow = "allow"
 needless_return = "allow"

native-engine/datafusion-ext-functions/src/spark_strings.rs

@@ -176,7 +176,7 @@ pub fn string_concat(args: &[ColumnarValue]) -> Result<ColumnarValue> {
         }
 
         // concat
-        let initial = Some("".to_string());
+        let initial = Some(String::new());
         let result = args.iter().fold(initial, |mut acc, rhs| {
             if let Some(ref mut inner) = acc {
                 match rhs {
@@ -401,8 +401,8 @@ mod test {
         // positive case
         let r = string_repeat(&vec![
             ColumnarValue::Array(Arc::new(StringArray::from_iter(vec![
-                Some(format!("123")),
-                Some(format!("a")),
+                Some("123".to_string()),
+                Some("a".to_string()),
                 None,
             ]))),
             ColumnarValue::Scalar(ScalarValue::from(3_i32)),
@@ -416,8 +416,8 @@ mod test {
         // repeat with n < 0
         let r = string_repeat(&vec![
             ColumnarValue::Array(Arc::new(StringArray::from_iter(vec![
-                Some(format!("123")),
-                Some(format!("a")),
+                Some("123".to_string()),
+                Some("a".to_string()),
                 None,
             ]))),
             ColumnarValue::Scalar(ScalarValue::from(-1_i32)),
@@ -431,8 +431,8 @@ mod test {
         // repeat with n = null
         let r = string_repeat(&vec![
             ColumnarValue::Array(Arc::new(StringArray::from_iter(vec![
-                Some(format!("123")),
-                Some(format!("a")),
+                Some("123".to_string()),
+                Some("a".to_string()),
                 None,
             ]))),
             ColumnarValue::Scalar(ScalarValue::Int32(None)),
@@ -450,9 +450,9 @@ mod test {
         // positive case
         let r = string_split(&vec![
             ColumnarValue::Array(Arc::new(StringArray::from_iter(vec![
-                Some(format!("123,456,,,789,")),
-                Some(format!("123")),
-                Some(format!("")),
+                Some("123,456,,,789,".to_string()),
+                Some("123".to_string()),
+                Some(String::new()),
                 None,
             ]))),
             ColumnarValue::Scalar(ScalarValue::from(",")),
@@ -485,16 +485,16 @@ mod test {
         // positive case
         let r = string_concat(&vec![
             ColumnarValue::Array(Arc::new(StringArray::from_iter(vec![
-                Some(format!("123")),
+                Some("123".to_string()),
                 None,
             ]))),
             ColumnarValue::Array(Arc::new(StringArray::from_iter(vec![
-                Some(format!("444")),
-                Some(format!("456")),
+                Some("444".to_string()),
+                Some("456".to_string()),
             ]))),
             ColumnarValue::Array(Arc::new(StringArray::from_iter(vec![
-                Some(format!("")),
-                Some(format!("")),
+                Some(String::new()),
+                Some(String::new()),
             ]))),
             ColumnarValue::Scalar(ScalarValue::from("SomeScalar")),
         ])?;
@@ -511,16 +511,16 @@ mod test {
         let r = string_concat_ws(&vec![
             ColumnarValue::Scalar(ScalarValue::from("||")),
             ColumnarValue::Array(Arc::new(StringArray::from_iter(vec![
-                Some(format!("123")),
+                Some("123".to_string()),
                 None,
             ]))),
             ColumnarValue::Array(Arc::new(StringArray::from_iter(vec![
                 None,
-                Some(format!("456")),
+                Some("456".to_string()),
             ]))),
             ColumnarValue::Array(Arc::new(StringArray::from_iter(vec![
-                Some(format!("")),
-                Some(format!("")),
+                Some(String::new()),
+                Some(String::new()),
             ]))),
             ColumnarValue::Array(Arc::new({
                 let mut list_builder = ListBuilder::new(StringBuilder::new());

native-engine/datafusion-ext-plans/src/agg_exec.rs

@@ -765,7 +765,7 @@ mod fuzztest {
         let partial_agg = Arc::new(AggExec::try_new(
             HashAgg,
             vec![GroupingExpr {
-                field_name: format!("key"),
+                field_name: "key".to_string(),
                 expr: phys_expr::col("key", &schema)?,
             }],
             vec![
@@ -792,7 +792,7 @@ mod fuzztest {
         let final_agg = Arc::new(AggExec::try_new(
             HashAgg,
             vec![GroupingExpr {
-                field_name: format!("key"),
+                field_name: "key".to_string(),
                 expr: phys_expr::col("key", &schema)?,
             }],
             vec![

native-engine/datafusion-ext-plans/src/common/cached_exprs_evaluator.rs

@@ -331,7 +331,7 @@ struct CachedExpr {
 
 impl Display for CachedExpr {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
-        write!(f, "{:?}", self)
+        write!(f, "{self:?}")
     }
 }
 

native-engine/datafusion-ext-plans/src/common/execution_context.rs

@@ -593,7 +593,7 @@ impl ExecutionContext {
                 if !task_running {
                     panic!("output_with_sender[{desc}] canceled due to task finished/killed");
                 } else {
-                    panic!("output_with_sender[{desc}] error: {}", err.to_string());
+                    panic!("output_with_sender[{desc}] error: {err}");
                 }
             }
             Ok::<_, DataFusionError>(())

native-engine/datafusion-ext-plans/src/common/row_null_checker.rs

@@ -127,7 +127,7 @@ impl RowNullChecker {
             }
             other => {
                 // For unsupported types, panic
-                panic!("unsupported data type in RowNullChecker: {:?}", other)
+                panic!("unsupported data type in RowNullChecker: {other:?}")
             }
         }
     }