Skip to content

[AURON #1917] Clean up Clippy format/string lints#1948

Merged
cxzl25 merged 1 commit intoapache:masterfrom
lemorage:lints
Jan 26, 2026
Merged

[AURON #1917] Clean up Clippy format/string lints#1948
cxzl25 merged 1 commit intoapache:masterfrom
lemorage:lints

Conversation

@lemorage
Copy link
Contributor

Which issue does this PR close?

Closes #1917

Rationale for this change

Improve Rust code quality.

What changes are included in this PR?

Are there any user-facing changes?

How was this patch tested?

@yew1eb
Copy link
Contributor

yew1eb commented Jan 23, 2026

Thanks for your first contribution! LGTM.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #1917 by cleaning up Clippy lints related to format/string operations. The changes modernize string formatting to use Rust 2021+ inline format arguments and eliminate unnecessary format!() calls.

Changes:

  • Removed useless_format, uninlined_format_args, and to_string_in_format_args from allowed Clippy lints in Cargo.toml
  • Converted old-style format strings (format!("{}", var)) to inline format arguments (format!("{var}"))
  • Replaced format!("literal") with .to_string() or String::new() for better performance and clarity

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Removed three format/string lint suppressions to enable stricter code quality checks
native-engine/datafusion-ext-plans/src/sort_exec.rs Updated write! macro to use inline format arguments
native-engine/datafusion-ext-plans/src/shuffle/mod.rs Modernized format string in Partitioning display implementation
native-engine/datafusion-ext-plans/src/parquet_sink_exec.rs Updated log warning messages to use inline format arguments
native-engine/datafusion-ext-plans/src/orc_exec.rs Extensively updated display formatting and test assertions throughout the file
native-engine/datafusion-ext-plans/src/common/row_null_checker.rs Updated panic message to use inline format arguments
native-engine/datafusion-ext-plans/src/common/execution_context.rs Modernized panic message formatting
native-engine/datafusion-ext-plans/src/common/cached_exprs_evaluator.rs Simplified Display implementation using inline format arguments
native-engine/datafusion-ext-plans/src/agg_exec.rs Replaced format!("key") with .to_string() for better performance
native-engine/datafusion-ext-functions/src/spark_strings.rs Replaced format!("") with String::new() and format!("literal") with .to_string() in test cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cxzl25 cxzl25 merged commit 87de6be into apache:master Jan 26, 2026
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up [workspace.lints.clippy] - Format/String lints

4 participants