[AURON #1917] Clean up Clippy format/string lints#1948
Merged
cxzl25 merged 1 commit intoapache:masterfrom Jan 26, 2026
Merged
Conversation
Contributor
|
Thanks for your first contribution! LGTM. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #1917 by cleaning up Clippy lints related to format/string operations. The changes modernize string formatting to use Rust 2021+ inline format arguments and eliminate unnecessary format!() calls.
Changes:
- Removed
useless_format,uninlined_format_args, andto_string_in_format_argsfrom allowed Clippy lints in Cargo.toml - Converted old-style format strings (
format!("{}", var)) to inline format arguments (format!("{var}")) - Replaced
format!("literal")with.to_string()orString::new()for better performance and clarity
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Removed three format/string lint suppressions to enable stricter code quality checks |
| native-engine/datafusion-ext-plans/src/sort_exec.rs | Updated write! macro to use inline format arguments |
| native-engine/datafusion-ext-plans/src/shuffle/mod.rs | Modernized format string in Partitioning display implementation |
| native-engine/datafusion-ext-plans/src/parquet_sink_exec.rs | Updated log warning messages to use inline format arguments |
| native-engine/datafusion-ext-plans/src/orc_exec.rs | Extensively updated display formatting and test assertions throughout the file |
| native-engine/datafusion-ext-plans/src/common/row_null_checker.rs | Updated panic message to use inline format arguments |
| native-engine/datafusion-ext-plans/src/common/execution_context.rs | Modernized panic message formatting |
| native-engine/datafusion-ext-plans/src/common/cached_exprs_evaluator.rs | Simplified Display implementation using inline format arguments |
| native-engine/datafusion-ext-plans/src/agg_exec.rs | Replaced format!("key") with .to_string() for better performance |
| native-engine/datafusion-ext-functions/src/spark_strings.rs | Replaced format!("") with String::new() and format!("literal") with .to_string() in test cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cxzl25
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1917
Rationale for this change
Improve Rust code quality.
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?