Skip to content

disable netty off-heap memory usage in BlazeShuffleManager #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lihao712 merged 1 commit into from
Jun 5, 2025
Merged

disable netty off-heap memory usage in BlazeShuffleManager #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...rk3/src/main/scala/org/apache/spark/sql/execution/blaze/shuffle/BlazeShuffleManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ import org.blaze.sparkver
class BlazeShuffleManager(conf: SparkConf) extends ShuffleManager with Logging {
val sortShuffleManager = new SortShuffleManager(conf)

// disable other off-heap memory usages
System.setProperty("spark.memory.offHeap.enabled", "false")
System.setProperty("io.netty.maxDirectMemory", "0")
System.setProperty("io.netty.noPreferDirect", "true")
System.setProperty("io.netty.noUnsafe", "true")

if (!conf.getBoolean("spark.shuffle.spill", defaultValue = true)) {
logWarning(
"spark.shuffle.spill was set to false, but this configuration is ignored as of Spark 1.6+." +
Expand Down
5 changes: 0 additions & 5 deletions .../src/main/scala/org/apache/spark/sql/execution/blaze/shuffle/BlazeShuffleWriterBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ abstract class BlazeShuffleWriterBase[K, V](metrics: ShuffleWriteMetricsReporter
extends ShuffleWriter[K, V]
with Logging {

// disable other off-heap memory usages
System.setProperty("spark.memory.offHeap.enabled", "false")
System.setProperty("io.netty.maxDirectMemory", "0")
System.setProperty("io.netty.noPreferDirect", "true")

protected var partitionLengths: Array[Long] = Array[Long]()
private var mapStatus: Option[MapStatus] = None

Expand Down
Loading