fix all warnings

native-engine/datafusion-ext-commons/src/algorithm/loser_tree.rs

@@ -58,7 +58,7 @@ impl<T: ComparableForLoserTree> LoserTree<T> {
         &self.values[0]
     }
 
-    pub fn peek_mut(&mut self) -> LoserTreePeekMut<T> {
+    pub fn peek_mut(&mut self) -> LoserTreePeekMut<'_, T> {
         LoserTreePeekMut {
             tree: self,
             dirty: false,

native-engine/datafusion-ext-commons/src/algorithm/rdx_queue.rs

@@ -67,7 +67,7 @@ impl<T: KeyForRadixQueue> RadixQueue<T> {
         &self.values[self.entries.get(self.cur_rdx).cloned().unwrap_or_default()]
     }
 
-    pub fn peek_mut(&mut self) -> RadixTournamentTreePeekMut<T> {
+    pub fn peek_mut(&mut self) -> RadixTournamentTreePeekMut<'_, T> {
         RadixTournamentTreePeekMut {
             tree: self,
             dirty: false,

native-engine/datafusion-ext-commons/src/io/mod.rs

@@ -15,7 +15,7 @@
 use std::io::{Read, Write};
 
 use arrow::{
-    array::{Array, ArrayRef, RecordBatchOptions},
+    array::{ArrayRef, RecordBatchOptions},
     datatypes::SchemaRef,
     record_batch::RecordBatch,
 };

native-engine/datafusion-ext-commons/src/lib.rs

@@ -16,7 +16,6 @@
 #![feature(core_intrinsics)]
 #![feature(slice_swap_unchecked)]
 #![feature(vec_into_raw_parts)]
-#![feature(let_chains)]
 
 use blaze_jni_bridge::conf::{
     BATCH_SIZE, IntConf, SUGGESTED_BATCH_MEM_SIZE, SUGGESTED_BATCH_MEM_SIZE_KWAY_MERGE,

native-engine/datafusion-ext-functions/src/lib.rs

@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![feature(let_chains)]
-
 use std::sync::Arc;
 
 use datafusion::{common::Result, logical_expr::ScalarFunctionImplementation};

native-engine/datafusion-ext-plans/src/agg/spark_udaf_wrapper.rs

@@ -444,7 +444,7 @@ impl SparkUDAFMemTracker {
         Ok(jni_call!(SparkUDAFMemTracker(self.obj.as_obj()).updateUsed()-> bool)?)
     }
 
-    pub fn as_obj(&self) -> JObject {
+    pub fn as_obj(&self) -> JObject<'_> {
         self.obj.as_obj()
     }
 }

native-engine/datafusion-ext-plans/src/common/timer_helper.rs

@@ -27,11 +27,16 @@ use futures::{FutureExt, future::BoxFuture};
 
 pub trait TimerHelper {
     fn with_timer<T>(&self, f: impl FnOnce() -> T) -> T;
-    fn with_timer_async<'a, T>(&'a self, f: impl Future<Output = T> + Send + 'a) -> BoxFuture<T>;
+    fn with_timer_async<'a, T>(
+        &'a self,
+        f: impl Future<Output = T> + Send + 'a,
+    ) -> BoxFuture<'a, T>;
 
     fn exclude_timer<T>(&self, f: impl FnOnce() -> T) -> T;
-    fn exclude_timer_async<'a, T>(&'a self, f: impl Future<Output = T> + Send + 'a)
-    -> BoxFuture<T>;
+    fn exclude_timer_async<'a, T>(
+        &'a self,
+        f: impl Future<Output = T> + Send + 'a,
+    ) -> BoxFuture<'a, T>;
 
     fn duration(&self) -> Duration;
     fn sub_duration(&self, duration: Duration);
@@ -45,7 +50,10 @@ impl TimerHelper for Time {
         f()
     }
 
-    fn with_timer_async<'a, T>(&'a self, f: impl Future<Output = T> + Send + 'a) -> BoxFuture<T> {
+    fn with_timer_async<'a, T>(
+        &'a self,
+        f: impl Future<Output = T> + Send + 'a,
+    ) -> BoxFuture<'a, T> {
         let time = self.clone();
         let start_time = Instant::now();
         f.inspect(move |_| time.add_duration(start_time.elapsed()))
@@ -62,7 +70,7 @@ impl TimerHelper for Time {
     fn exclude_timer_async<'a, T>(
         &'a self,
         f: impl Future<Output = T> + Send + 'a,
-    ) -> BoxFuture<T> {
+    ) -> BoxFuture<'a, T> {
         let time = self.clone();
         let start_time = Instant::now();
         f.inspect(move |_| time.sub_duration(start_time.elapsed()))

native-engine/datafusion-ext-plans/src/generate_exec.rs

@@ -242,6 +242,7 @@ fn execute_generate(
                                 }
                             }
                             $from_row_id = $to_row_id;
+                            let _ = $from_row_id; // suppress unused warning
                         }};
                     }
 

native-engine/datafusion-ext-plans/src/lib.rs

@@ -19,7 +19,6 @@
 #![feature(get_mut_unchecked)]
 #![feature(portable_simd)]
 #![feature(ptr_as_ref_unchecked)]
-#![feature(let_chains)]
 
 // execution plan implementations
 pub mod agg_exec;

native-engine/datafusion-ext-plans/src/sort_exec.rs

@@ -364,9 +364,9 @@ impl SortedBlock for InMemSortedBlock {
 
 struct SpillSortedBlock {
     pruned_schema: SchemaRef,
-    spill: Box<dyn Spill>,
     spill_reader: SpillCompressedReader<'static>,
     cur_key_reader: SortedKeysReader,
+    _spill: Box<dyn Spill>,
 }
 
 impl SortedBlock for SpillSortedBlock {
@@ -479,9 +479,9 @@ impl SortedBlockBuilder<SpillSortedBlock, SqueezeKeyCollector> for SpillSortedBl
         };
         Ok(SpillSortedBlock {
             pruned_schema: self.pruned_schema,
-            spill,
             spill_reader,
             cur_key_reader: SortedKeysReader::default(),
+            _spill: spill,
         })
     }
 }