Skip to content

[AURON #1434] Use Maven-native version extraction instead of xmllint for better portability#1435

Merged
merrily01 merged 1 commit intoapache:masterfrom
merrily01:fix-xmllint
Oct 17, 2025
Merged

[AURON #1434] Use Maven-native version extraction instead of xmllint for better portability#1435
merrily01 merged 1 commit intoapache:masterfrom
merrily01:fix-xmllint

Conversation

@merrily01
Copy link
Copy Markdown
Member

@merrily01 merrily01 commented Oct 13, 2025

Which issue does this PR close?

Closes #1434 .

Rationale for this change

Previously, the build script relied on xmllint to parse pom.xml and extract
project.version, which caused build failures in environments where xmllint
is not available (e.g., GitHub Actions or minimal Docker images).

This change replaces it with:

  ./build/mvn help:evaluate -N -Dexpression=project.version -Pspark-${SPARK_VER} -q -DforceStdout

This approach uses Maven’s built-in model evaluation and works consistently
across platforms without additional dependencies.

What changes are included in this PR?

Are there any user-facing changes?

How was this patch tested?

@github-actions github-actions bot added the build label Oct 13, 2025
Copy link
Copy Markdown
Contributor

@ShreyeshArangath ShreyeshArangath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@slfan1989
Copy link
Copy Markdown
Contributor

LGTM +1

Copy link
Copy Markdown
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @merrily01

@merrily01
Copy link
Copy Markdown
Member Author

Merged. Thanks for the review @ShreyeshArangath @slfan1989 @wForget

@merrily01 merrily01 merged commit 76ea6c0 into apache:master Oct 17, 2025
84 checks passed
@guixiaowen
Copy link
Copy Markdown
Contributor

guixiaowen commented Oct 20, 2025

@merrily01 me Errors during compilation after merging the code are shown in the figure.
截屏2025-10-21 00 24 06

The built file information is

auron-build-info.properties.txt

The build command is: ./auron-build.sh --pre --sparkver 3.5 --scalaver 2.12 -DskipBuildNative -Djansi.passthrough=true -s /Users/didi/.m3/settings.xml -Dmaven

@merrily01
Copy link
Copy Markdown
Member Author

@merrily01 me Errors during compilation after merging the code are shown in the figure. 截屏2025-10-21 00 24 06

The built file information is

auron-build-info.properties.txt

The build command is: ./auron-build.sh --pre --sparkver 3.5 --scalaver 2.12 -DskipBuildNative -Djansi.passthrough=true -s /Users/didi/.m3/settings.xml -Dmaven

It looks like the issue comes from local Maven environment?(probably related to the HTTP repo blocking in your settings.xml)

image

Could you please try running the same command with a standard Maven setup (e.g., using ~/.m2/settings.xml)?

I just verified that and works fine on my side.

@guixiaowen
Copy link
Copy Markdown
Contributor

@merrily01 me Errors during compilation after merging the code are shown in the figure. 截屏2025-10-21 00 24 06
The built file information is
auron-build-info.properties.txt
The build command is: ./auron-build.sh --pre --sparkver 3.5 --scalaver 2.12 -DskipBuildNative -Djansi.passthrough=true -s /Users/didi/.m3/settings.xml -Dmaven

It looks like the issue comes from local Maven environment?(probably related to the HTTP repo blocking in your settings.xml)

image Could you please try running the same command with a standard Maven setup (e.g., using ~/.m2/settings.xml)?

I just verified that and works fine on my side.

@merrily01 Thank you very much for the reply. I'll take another look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

./auron-build.sh: line 285: xmllint: command not found

5 participants