[AURON #1473] Rename module spark-extension-shims-spark3 to spark-extension-shims-spark.#1474
Merged
turboFei merged 1 commit intoapache:masterfrom Oct 23, 2025
Merged
Conversation
Contributor
Author
|
@richox Could you please help review this PR? Thank you very much! |
…rk-extension-shims-spark.
cxzl25
approved these changes
Oct 21, 2025
richox
approved these changes
Oct 22, 2025
Contributor
|
as we are using scala-paradise for conditional compiling with different spark version now, the shim package can be further merged into spark-extension module in the future. |
Contributor
Author
@richox Thank you for your explanation! This approach makes sense to me as it effectively avoids code duplication and is a good optimization. |
Contributor
Author
turboFei
approved these changes
Oct 23, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1473.
We plan to introduce support for
Spark 4. Currently, the module namespark-extension-shims-spark3is tightly coupled withSpark 3-specificversions. To make the module naming more general and version-agnostic, we should rename it tospark-extension-shims-spark.This change will make it easier to extend support for multiple Spark versions (e.g., Spark 3.x, Spark 4.x) without duplicating shim module definitions.
Rationale for this change
The local compilation passes.
What changes are included in this PR?
Rename spark-extension-shims-spark3 to spark-extension-shims-spark.
Are there any user-facing changes?
No.
How was this patch tested?
CI