Skip to content

[AURON #1595] Enforce skiptest=false to not miss failing UT #1596

Merged
cxzl25 merged 20 commits intoapache:masterfrom
ShreyeshArangath:sarangat/fix-ut
Dec 1, 2025
Merged

[AURON #1595] Enforce skiptest=false to not miss failing UT #1596
cxzl25 merged 20 commits intoapache:masterfrom
ShreyeshArangath:sarangat/fix-ut

Conversation

@ShreyeshArangath
Copy link
Contributor

@ShreyeshArangath ShreyeshArangath commented Nov 3, 2025

Which issue does this PR close?

Closes #1595

Rationale for this change

  • Ensure UTs run in pre-builds to catch regressions before merging.
  • Correct Exchange conversion behavior to respect feature flags/shuffle manager.

What changes are included in this PR?

  • CI: Run tests in pre-builds: append --skiptests false
  • Core: Fix failing UTs

Are there any user-facing changes?

  • Behavior corrected in native Exchange conversion which was causing test failures
  • No public API changes.

How was this patch tested?

  • CI pre-build runs UTs via --skiptests false.

Note: I'll create another PR to add support for publishing test reports (draft: PR)

@ShreyeshArangath
Copy link
Contributor Author

ShreyeshArangath commented Nov 3, 2025

The Celeborn TPC-DS failure seems unrelated to this PR (OOM), we might have to investigate why this is happening. If anyone has a lead on this, please do let me know.

Caused by: java.lang.RuntimeException: poll record batch error: Execution error: native execution panics: Execution error: Execution error: output_with_sender[Shuffle] error: Execution error: output_with_sender[Agg] error: Execution error: output_with_sender[Expand] error: Execution error: output_with_sender[Expand]: output() returns error: Execution error: Execution error: output_with_sender[Project] error: Execution error: output_with_sender[Agg] error: Execution error: output_with_sender[IpcReader] error: Execution error: output_with_sender[IpcReader]: output() returns error: External error: Java exception thrown at native-engine/datafusion-ext-plans/src/ipc_reader_exec.rs:216: java.io.IOException: External error: Java exception thrown at native-engine/datafusion-ext-plans/src/ipc_reader_exec.rs:339: java.lang.OutOfMemoryError: Java heap space
at org.apache.auron.jni.JniBridge.nextBatch(Native Method)
at org.apache.auron.jni.AuronCallNativeWrapper.loadNextBatch(AuronCallNativeWrapper.java:118)
... 32 more

Edit: looks like the re-run succeeded; we should still look into tuning the TPC-DS execution. Maybe, we are running very close to the heap limits.

@slfan1989
Copy link
Contributor

slfan1989 commented Nov 4, 2025

LGTM

@guixiaowen
Copy link
Contributor

LGTM

@ShreyeshArangath
Copy link
Contributor Author

@guixiaowen can you help fix the failing UT introduced by #1585? Thanks

Copy link
Contributor Author

@ShreyeshArangath ShreyeshArangath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the existing tests to not fail

@ShreyeshArangath
Copy link
Contributor Author

ShreyeshArangath commented Nov 21, 2025

@SteNicholas @merrily01 Can you please help me merge this to prevent any further unit test failures?

@SteNicholas
Copy link
Member

cc @richox.

@github-actions github-actions bot removed the native label Nov 25, 2025
@ShreyeshArangath
Copy link
Contributor Author

ShreyeshArangath commented Dec 1, 2025

@richox / @cxzl25, could you please take a look?

@cxzl25 cxzl25 merged commit e62f5ef into apache:master Dec 1, 2025
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce skiptest=false to not miss failing UT

7 participants