Skip to content

[AURON #1617] Fix NativeConvertersSuite cast trim-disable test failures #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richox merged 2 commits into from
Nov 22, 2025
Merged

[AURON #1617] Fix NativeConvertersSuite cast trim-disable test failures #1618

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d8af10
[AURON #1617] Fix NativeConvertersSuite cast trim-disable test failures
yew1eb Nov 11, 2025
45a76fe
fix code style
yew1eb Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions ...-extension-shims-spark/src/test/scala/org/apache/spark/sql/auron/AuronSQLTestHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,31 +16,27 @@
*/
package org.apache.spark.sql.auron

import org.apache.spark.SparkEnv
import org.apache.spark.sql.internal.SQLConf

trait AuronSQLTestHelper {
def withEnvConf(pairs: (String, String)*)(f: => Unit): Unit = {
val env = SparkEnv.get
if (env == null) {
throw new IllegalStateException("SparkEnv is not initialized")
}
val conf = env.conf
val conf = SQLConf.get
val (keys, values) = pairs.unzip
val currentValues = keys.map { key =>
if (conf.contains(key)) {
Some(conf.get(key))
Some(conf.getConfString(key))
} else {
None
}
}
(keys, values).zipped.foreach { (k, v) =>
conf.set(k, v)
conf.setConfString(k, v)
}
try f
finally {
keys.zip(currentValues).foreach {
case (key, Some(value)) => conf.set(key, value)
case (key, None) => conf.remove(key)
case (key, Some(value)) => conf.setConfString(key, value)
case (key, None) => conf.unsetConf(key)
}
}
}
Expand Down
Loading