[AURON #1665] Override verboseStringWithOperatorId in NativeFileSourceScanBase#1643
Merged
richox merged 6 commits intoapache:masterfrom Dec 1, 2025
Merged
[AURON #1665] Override verboseStringWithOperatorId in NativeFileSourceScanBase#1643richox merged 6 commits intoapache:masterfrom
richox merged 6 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@merrily01 @richox the NativeFileSourceScan's explain ouput currently diverges from vanilla spark and forces all metadata into a truncated "Arguments" line that loses information. this change mirrors vanilla spark' formatting exactly, so it have no side effects. |
…peratorId with vanilla Spark
…eSourceScanBase
yew1eb
changed the title
5 tasks
yew1eb
changed the title
yew1eb
changed the title
zuston
approved these changes
Nov 28, 2025
|
|
||
| override protected def doCanonicalize(): SparkPlan = basedFileScan.canonicalized | ||
|
|
||
| override def verboseStringWithOperatorId(): String = { |
Member
There was a problem hiding this comment.
Could you add the reference url of spark in comment for better understanding ?
zuston
approved these changes
Nov 28, 2025
xumingming
reviewed
Nov 28, 2025
| */ | ||
| override def verboseStringWithOperatorId(): String = { | ||
| val metadataStr = basedFileScan.metadata.toSeq.sorted | ||
| .filterNot { |
Contributor
There was a problem hiding this comment.
nit: How about call super.verboseStringWithOperatorId and replace the nodeName, it might be simpler. The code here seems a little complicated which is almost identical to super.
Member
There was a problem hiding this comment.
Could you directly use the upstream method? If so, it's pretty nice
richox
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Close #1665.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?
Vanilla Spark：
Master:
PR:
