[AURON #1708] Fix spark_normalize_nan_and_zero None#1709
Merged
cxzl25 merged 1 commit intoapache:masterfrom Dec 11, 2025
Merged
[AURON #1708] Fix spark_normalize_nan_and_zero None#1709cxzl25 merged 1 commit intoapache:masterfrom
cxzl25 merged 1 commit intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the spark_normalize_nan_and_zero function would fail when encountering null Float32/Float64 scalar values. The fix adds explicit handling for None values to return them as-is, aligning with Spark's behavior and the function's existing array handling logic which already supports null values within arrays.
Key Changes:
- Added None value handling for Float32 and Float64 scalar inputs
- Updated error message to reflect None support
- Added comprehensive unit tests for null scalar handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
richox
approved these changes
Dec 11, 2025
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1708
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?