[AURON #1845] Fix StringSplit conversion#1846
Merged
richox merged 1 commit intoapache:masterfrom Jan 17, 2026
Merged
Conversation
Contributor
|
one concern: UDFWrapper(split, [1]) fallbacks one item from the result array. but UDFWrapper(split)[1] fallbacks the whole array, increasing a lot of fallback costs. |
b5ad7b2 to
496e7a3
Compare
496e7a3 to
91f0f18
Compare
91f0f18 to
d56f165
Compare
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the StringSplit conversion to correctly specify that it returns an array of strings rather than a single string. The issue was that the native function conversion was incorrectly declaring the return type as StringType when it should be ArrayType(StringType).
Changes:
- Added
ArrayTypeto imports and consolidated type imports - Added defensive
.toStringcalls when accessingLiteral.value - Fixed return type from
StringTypetoArrayType(StringType)for the native StringSplit function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
richox
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1845
Rationale for this change
before:
ProjectExec [UDFWrapper(split(col1#1, ,, -1)[0]) AS #5], schema=[#5:Utf8;N]after:
ProjectExec [(spark_ext_function_Spark_StringSplit(#1@0, ,)).[1] AS #5], schema=[#5:Utf8;N]What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?