Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion native-engine/auron-jni-bridge/src/jni_bridge.rs
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ impl JavaClasses<'static> {

pub fn get() -> &'static JavaClasses<'static> {
unsafe {
// safety: JNI_JAVA_CLASSES must be initialized frist
// safety: JNI_JAVA_CLASSES must be initialized first
JNI_JAVA_CLASSES.get_unchecked()
}
}
Expand Down
4 changes: 2 additions & 2 deletions native-engine/auron-serde/src/from_proto.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,7 @@ fn try_parse_physical_sort_expr(
input: &Arc<dyn ExecutionPlan>,
sort: &Box<SortExecNode>,
) -> Result<Vec<PhysicalSortExpr>, PlanSerDeError> {
let pyhsical_sort_expr = sort
let physical_sort_expr = sort
.expr
.iter()
.map(|expr| {
Expand Down Expand Up @@ -1111,7 +1111,7 @@ fn try_parse_physical_sort_expr(
}
})
.collect::<Result<Vec<_>, _>>()?;
Ok(pyhsical_sort_expr)
Ok(physical_sort_expr)
}

pub fn parse_protobuf_partitioning(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ pub fn create_array_interleaver(
NonNull::new_unchecked(take_value_ptrs[take_value_ptr_idx] as *mut u8);
take_value_ptr_idx += 1;

// for continous elements, just extend the area to copy
// for continuous elements, just extend the area to copy
// otherwise, copy current area end move to the next area
if src_end_ptr != value_ptr {
prefetch_read_data!(value_ptr.as_ptr()); // prefetch next while copying current
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ impl<W: Write> IoCompressionWriter<W> {
match self {
IoCompressionWriter::LZ4(w) => {
w.try_finish()
.or_else(|_| df_execution_err!("ipc compresion error"))?;
.or_else(|_| df_execution_err!("ipc compression error"))?;
}
IoCompressionWriter::ZSTD(w) => {
w.do_finish()?;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ fn invoke_udf(
params_batch: RecordBatch,
result_schema: SchemaRef,
) -> Result<ArrayRef> {
// evalute via context
// evaluate via context
let struct_array = StructArray::from(params_batch);
let mut export_ffi_array = FFI_ArrowArray::new(&struct_array.to_data());
let mut import_ffi_array = FFI_ArrowArray::empty();
Expand Down
4 changes: 2 additions & 2 deletions native-engine/datafusion-ext-exprs/src/string_ends_with.rs
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,10 @@ mod test {
Some("rr".to_string()),
Some("roser r".to_string()),
]));
// create a shema with the field
// create a schema with the field
let schema = Arc::new(Schema::new(vec![Field::new("col2", DataType::Utf8, true)]));

// create a RecordBatch with the shema and StringArray
// create a RecordBatch with the schema and StringArray
let batch =
RecordBatch::try_new(schema, vec![string_array]).expect("Error creating RecordBatch");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ impl PhysicalExpr for CachedExpr {
}
}

/// A struct holding all evaluated values of cachable expressions
/// A struct holding all evaluated values of cacheable expressions
#[derive(Clone)]
struct Cache {
values: Arc<Mutex<Vec<Option<ColumnarValue>>>>,
Expand Down
2 changes: 1 addition & 1 deletion native-engine/datafusion-ext-plans/src/sort_exec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1266,7 +1266,7 @@ impl KeyCollector for InMemRowsKeyCollector {
assert_eq!(self.offsets.len() - 1, num_rows);
let mut rows = row_converter.empty_rows(0, 0);
unsafe {
// safety: acces rows.buffer/offsets
// safety: access rows.buffer/offsets
struct XRows {
buffer: Vec<u8>,
offsets: Vec<usize>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ abstract class NativeWindowBase(
.addAllPartitionSpec(nativePartitionSpecExprs.asJava)
.addAllOrderSpec(nativeOrderSpecExprs.asJava)

// WindowGrupLimitExec does not output window cols
// WindowGroupLimitExec does not output window cols
groupLimit match {
case Some(limit) =>
nativeWindowExec.setGroupLimit(WindowGroupLimit.newBuilder().setK(limit))
Expand Down