You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
replace RecordBatch::try_new with RecordBatch::try_new_with_option
so we don't need to fallback this operator.
Creating a new RecordBatch with option does not seem to solve this isssue, the columns will be empty due to the schema fields being used as projection.
Sorry, I noticed that RecordBatch seems to allow columns to be empty, I will try to do that.
wForget
changed the title
Fallback when BroadcastJoin output is empty
Create RecordBatch with num_rows option to avoid bhj error caused by empty output_schema
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #682
Rationale for this change
Native schema of BroadcastJoin cannot be empty.
https://github.com/kwai/blaze/blob/b662097e7379c4a5912706d58562658b02274335/native-engine/datafusion-ext-plans/src/joins/bhj/full_join.rs#L126
Are there any user-facing changes?