Skip to content

[BLAZE-706] Fix year/month/day functions data type #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richox merged 1 commit into from
Dec 19, 2024
Merged

[BLAZE-706] Fix year/month/day functions data type #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions spark-extension-shims-spark3/src/test/scala/org/apache/spark/sql/blaze/BlazeQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,20 @@ class BlazeQuerySuite extends org.apache.spark.sql.QueryTest with BaseBlazeSQLSu
}
}

test("test filter with year function") {
withTable("t1") {
sql("create table t1 using parquet as select '2024-12-18' as event_time")
checkAnswer(
sql(
"""
|select year, count(*)
|from (select event_time, year(event_time) as year from t1) t
|where year <= 2024
|group by year
|""".stripMargin),
Seq(Row(2024, 1))
)
}
}

}
6 changes: 3 additions & 3 deletions spark-extension/src/main/scala/org/apache/spark/sql/blaze/NativeConverters.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,9 +873,9 @@ object NativeConverters extends Logging {
case XxHash64(children, 42L) =>
buildExtScalarFunction("XxHash64", children, LongType)

case Year(child) => buildExtScalarFunction("Year", child :: Nil, DateType)
case Month(child) => buildExtScalarFunction("Month", child :: Nil, DateType)
case DayOfMonth(child) => buildExtScalarFunction("Day", child :: Nil, DateType)
case Year(child) => buildExtScalarFunction("Year", child :: Nil, IntegerType)
case Month(child) => buildExtScalarFunction("Month", child :: Nil, IntegerType)
case DayOfMonth(child) => buildExtScalarFunction("Day", child :: Nil, IntegerType)

// startswith is converted to scalar function in pruning-expr mode
case StartsWith(expr, Literal(prefix, StringType)) if isPruningExpr =>
Expand Down