Conversation
Resolving conflicted_file ArrowFFIExporter
merge NativeConverters
gy11233
changed the title
richox
reviewed
Feb 25, 2025
| acc_idx: IdxSelection<'_>, | ||
| partial_args: &[ArrayRef], | ||
| partial_arg_idx: IdxSelection<'_>, | ||
| batch_schema: SchemaRef, |
Contributor
There was a problem hiding this comment.
i suggest to create params_schema in constructor and remove this batch_schema parameter.
| } | ||
| } | ||
|
|
||
| struct AccUnsafeRowsColumn { |
Contributor
There was a problem hiding this comment.
i would like a better name like AccUDAFBufferRowsColumn because it is not only for UnsafeRows.
| )?) | ||
| } | ||
| AggFunction::Udaf => { | ||
| unreachable!("UDAF should be handled in create_declarative_agg") |
richox
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #577
Rationale for this change
Supports UDAF and aggregation functions based on DeclarativeAggregate and TypedImperativeAggregate.
What changes are included in this PR?
Are there any user-facing changes?