[BLAZE-902] Fix UnifflePartitionWriter invoke ShuffleWriteMetricsReporter#incWriteTime with nano seconds#903
Merged
richox merged 2 commits intoapache:masterfrom Mar 24, 2025
Merged
Conversation
…rter#incWriteTime with nano seconds
Member
Author
|
Ping @richox. |
richox
approved these changes
Mar 24, 2025
Contributor
|
ci issue is related to #899, so this pr can be merged without ci passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #902.
Rationale for this change
UnifflePartitionWritershould not invokeShuffleWriteMetricsReporter#incWriteTimewith milli seconds, which refers to RssShuffleWriter.java#L294.What changes are included in this PR?
Fix
UnifflePartitionWriterinvokeShuffleWriteMetricsReporter#incWriteTimewith nano seconds.Are there any user-facing changes?
No.