Skip to content

Added Favicon#401

Closed
ayushsingh199 wants to merge 1 commit into
apache:mainfrom
ayushsingh199:ayush2
Closed

Added Favicon#401
ayushsingh199 wants to merge 1 commit into
apache:mainfrom
ayushsingh199:ayush2

Conversation

@ayushsingh199

@ayushsingh199 ayushsingh199 commented Oct 17, 2024

Copy link
Copy Markdown

[Short description explaining the high-level reason for the pull request]

Changes

Added Favicon for the website!

Screenshot 2024-10-17 at 6 43 43 PM

Important

Add favicon to website by updating index.html to use burr-favicon.png.

  • HTML Update:
    • Added favicon by modifying the link tag in index.html to use burr-favicon.png as the icon.

This description was created by Ellipsis for a1dee60. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to a1dee60 in 18 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_yIDRVkXEwhjO965B


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Comment thread telemetry/ui/public/index.html
@skrawcz

skrawcz commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

Thanks @ayushsingh199. We also want this for the burr documentation page. I think you just need to do:

in conf.py under docs/

html_favicon = 'burr image file name' # and add the image to the docs folder too

@andreahlert

Copy link
Copy Markdown
Collaborator

Closing. The project now has a favicon and the website has been rebuilt with a new stack (PR #679). Thanks @ayushsingh199 for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants