[CELEBORN-1671] CelebornShuffleReader will try replica if create client failed#2854
Closed
FMX wants to merge 7 commits intoapache:mainfrom
Closed
[CELEBORN-1671] CelebornShuffleReader will try replica if create client failed#2854FMX wants to merge 7 commits intoapache:mainfrom
FMX wants to merge 7 commits intoapache:mainfrom
Conversation
FMX
changed the title
SteNicholas
approved these changes
Oct 28, 2024
zaynt4606
approved these changes
Oct 29, 2024
RexXiong
reviewed
Nov 1, 2024
| s"Failed to create client for $shuffleKey-$partitionId from host: ${location.hostAndFetchPort}") | ||
| } | ||
| } | ||
| val (_, locArr, pbOpenStreamListBuilder) = workerRequestMap.get(hostPort) |
Contributor
There was a problem hiding this comment.
nit: move these code to try block?
RexXiong
approved these changes
Nov 5, 2024
RexXiong
approved these changes
Nov 6, 2024
RexXiong
pushed a commit
that referenced
this pull request
Nov 6, 2024
…nt failed 1. To bypass exceptions when creating clients failed in CelebornShuffleReader in spark 3. 2. Client will try the location's replicas in reading locations. Allow clients to retry locations when creating clients failed. NO. Pass GA. Closes #2854 from FMX/b1671. Authored-by: mingji <fengmingxiao.fmx@alibaba-inc.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit 7dcd259) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Allow clients to retry locations when creating clients failed.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
Pass GA.