Feature encoding option for custom table AM #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gfphoenix78 merged 4 commits into apache:main from gfphoenix78:feature-encoding-option

Dec 28, 2023

Contributor

gfphoenix78 commented Dec 20, 2023

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
Learn the coding contribution guide, including our code conventions, workflow and more.
List your communication in the GitHub Issues or Discussions (if has or needed).
Document changes.
Add tests for the change
Pass make installcheck
Pass make -C src/test installcheck-cbdb-parallel
Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

gfphoenix78 force-pushed the feature-encoding-option branch from cbb9e53 to 794087b Compare

December 20, 2023 16:47

gfphoenix78 commented

View reviewed changes

src/include/access/reloptions.h Show resolved Hide resolved

gfphoenix78 commented

View reviewed changes

src/backend/access/common/reloptions_gp.c Outdated Show resolved Hide resolved

gfphoenix78 commented

View reviewed changes

src/backend/commands/tablecmds.c Show resolved Hide resolved

gfphoenix78 commented

View reviewed changes

src/backend/access/appendonly/appendonlyam_handler.c Outdated Show resolved Hide resolved

gfphoenix78 commented

View reviewed changes

src/backend/commands/tablecmds.c Outdated Show resolved Hide resolved

gfphoenix78 marked this pull request as ready for review

December 24, 2023 20:07

gfphoenix78 force-pushed the feature-encoding-option branch 2 times, most recently from 5a5004b to 657a8d9 Compare

December 27, 2023 01:08

gfphoenix78 changed the title ~~WIP: Feature encoding option~~ Feature encoding option for custom table AM


          Feature: expand ENCODING reloptions to am

fbda18a

This commit supports custom table AM to have its own encoding
options. The kernal has hard-coded encoding clause for AOCO.
The guc gp_default_storage_options is only considered by AOCO,
because the options may be different for other table AM.

avamingli reviewed

View reviewed changes

src/backend/commands/tablecmds.c Outdated Show resolved Hide resolved

src/backend/commands/tablecmds.c Outdated Show resolved Hide resolved

src/backend/access/common/reloptions_gp.c Show resolved Hide resolved

src/backend/access/common/reloptions_gp.c Show resolved Hide resolved

src/backend/access/common/reloptions_gp.c Outdated Show resolved Hide resolved

src/backend/access/common/reloptions_gp.c Show resolved Hide resolved

avamingli approved these changes

View reviewed changes


          clean code

c0aec6f

gfphoenix78 force-pushed the feature-encoding-option branch from 657a8d9 to c0aec6f Compare

December 28, 2023 05:01

gfphoenix78 added 2 commits

December 28, 2023 13:13

fix

b40c507


          fix2

55ff338

avamingli approved these changes

View reviewed changes

Contributor

avamingli left a comment

LGTM.

gfphoenix78 merged commit c9a8118 into apache:main

foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request


          Feature encoding option for custom table AM (apache#343)

78af23e

This commit supports custom table AM to have its own encoding
options. The kernal has hard-coded encoding clause for AOCO.
The guc gp_default_storage_options is only considered by AOCO,
because the options may be different for other table AM.

Co-authored-by: zhoujiaqi <[email protected]>
Reviewed-by: Zhang Mingli <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet